linux-kernel - Re: [PATCH] mfd: stmfx: Fix macro definition spelling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 13 May 2019 07:10:59 +0000
From:   Amelie DELAUNAY <amelie.delaunay@...com>
To:     Nathan Chancellor <natechancellor@...il.com>,
        Lee Jones <lee.jones@...aro.org>
CC:     Maxime Coquelin <mcoquelin.stm32@...il.com>,
        Alexandre TORGUE <alexandre.torgue@...com>,
        "linux-stm32@...md-mailman.stormreply.com" 
        <linux-stm32@...md-mailman.stormreply.com>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "clang-built-linux@...glegroups.com" 
        <clang-built-linux@...glegroups.com>
Subject: Re: [PATCH] mfd: stmfx: Fix macro definition spelling

On 5/11/19 3:23 AM, Nathan Chancellor wrote:
> Clang warns:
> 
> In file included from drivers/mfd/stmfx.c:13:
> include/linux/mfd/stmfx.h:7:9: warning: 'MFD_STMFX_H' is used as a
> header guard here, followed by #define of a different macro
> [-Wheader-guard]
> 
> Fixes: 06252ade9156 ("mfd: Add ST Multi-Function eXpander (STMFX) core driver")
> Link: https://github.com/ClangBuiltLinux/linux/issues/475
> Signed-off-by: Nathan Chancellor <natechancellor@...il.com>

Reviewed-by: Amelie Delaunay <amelie.delaunay@...com>

> ---
>   include/linux/mfd/stmfx.h | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/linux/mfd/stmfx.h b/include/linux/mfd/stmfx.h
> index d890595b89b6..3c67983678ec 100644
> --- a/include/linux/mfd/stmfx.h
> +++ b/include/linux/mfd/stmfx.h
> @@ -5,7 +5,7 @@
>    */
>   
>   #ifndef MFD_STMFX_H
> -#define MFX_STMFX_H
> +#define MFD_STMFX_H
>   
>   #include <linux/regmap.h>
>   
>