linux-kernel - [PATCH RESEND] mfd: rk808: Fix RK818 ID template

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 13 May 2019 10:29:43 +0200
From:   Heiko Stuebner <heiko@...ech.de>
To:     lee.jones@...aro.org
Cc:     linux-kernel@...r.kernel.org, Daniel Schultz <d.schultz@...tec.de>,
        stable@...r.kernel.org, Elaine Zhang <zhangqing@...k-chips.com>,
        Joseph Chen <chenjh@...k-chips.com>,
        Heiko Stuebner <heiko@...ech.de>
Subject: [PATCH RESEND] mfd: rk808: Fix RK818 ID template

From: Daniel Schultz <d.schultz@...tec.de>

The Rockchip PMIC driver can automatically detect connected component
versions by reading the ID_MSB and ID_LSB registers. The probe function
will always fail with RK818 PMICs because the ID_MSK is 0xFFF0 and the
RK818 template ID is 0x8181.

This patch changes this value to 0x8180.

Fixes: 9d6105e19f61 ("mfd: rk808: Fix up the chip id get failed")
Cc: stable@...r.kernel.org
Cc: Elaine Zhang <zhangqing@...k-chips.com>
Cc: Joseph Chen <chenjh@...k-chips.com>
Signed-off-by: Daniel Schultz <d.schultz@...tec.de>
Acked-by: Lee Jones <lee.jones@...aro.org>
[added Fixes and cc-stable]
Signed-off-by: Heiko Stuebner <heiko@...ech.de>
---
The original patch from Feburary 2018 got an Ack but never reached
the mfd-tree, so I ran into that problem this weekend as well.
So it would be really cool if this could be applied as fix :-) .

 include/linux/mfd/rk808.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/linux/mfd/rk808.h b/include/linux/mfd/rk808.h
index d3156594674c..338e0f6e2226 100644
--- a/include/linux/mfd/rk808.h
+++ b/include/linux/mfd/rk808.h
@@ -443,7 +443,7 @@ enum {
 enum {
 	RK805_ID = 0x8050,
 	RK808_ID = 0x0000,
-	RK818_ID = 0x8181,
+	RK818_ID = 0x8180,
 };
 
 struct rk808 {
-- 
2.20.1