linux-kernel - Re: [PATCH v2 6/6] staging: rtl8723bs: core: Move logical operator to previous line.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190513093324.GA21213@kroah.com>
Date:   Mon, 13 May 2019 11:33:24 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Vatsala Narang <vatsalanarang@...il.com>
Cc:     devel@...verdev.osuosl.org, julia.lawall@...6.fr,
        linux-kernel@...r.kernel.org, hdegoede@...hat.com,
        hadess@...ess.net
Subject: Re: [PATCH v2 6/6] staging: rtl8723bs: core: Move logical operator
 to previous line.

On Sun, May 05, 2019 at 06:52:53PM +0530, Vatsala Narang wrote:
> Move logical operator to previous line to get rid of checkpatch warning.
> 
> Signed-off-by: Vatsala Narang <vatsalanarang@...il.com>
> ---
>  drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c b/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c
> index 0b5bd047a552..b5e355de1199 100644
> --- a/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c
> +++ b/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c
> @@ -5656,9 +5656,9 @@ static u8 chk_ap_is_alive(struct adapter *padapter, struct sta_info *psta)
>  	);
>  	#endif
>  
> -	if ((sta_rx_data_pkts(psta) == sta_last_rx_data_pkts(psta))
> -		&& sta_rx_beacon_pkts(psta) == sta_last_rx_beacon_pkts(psta)
> -		&& sta_rx_probersp_pkts(psta) == sta_last_rx_probersp_pkts(psta)
> +	if ((sta_rx_data_pkts(psta) == sta_last_rx_data_pkts(psta)) &&
> +	    sta_rx_beacon_pkts(psta) == sta_last_rx_beacon_pkts(psta) &&
> +	     sta_rx_probersp_pkts(psta) == sta_last_rx_probersp_pkts(psta)

Odd, you should align these two lines, right?

>  	) {

This should go on the previous line.

thanks,

greg k-h