linux-kernel - Re: [PATCH 1/5] irqchip/renesas-irqc: Remove unneeded inclusion of <linux/spinlock.h>

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190513120447.l6gzewa5cb7riar7@verge.net.au>
Date:   Mon, 13 May 2019 14:04:47 +0200
From:   Simon Horman <horms@...ge.net.au>
To:     Geert Uytterhoeven <geert+renesas@...der.be>
Cc:     Thomas Gleixner <tglx@...utronix.de>,
        Jason Cooper <jason@...edaemon.net>,
        Marc Zyngier <marc.zyngier@....com>,
        linux-renesas-soc@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/5] irqchip/renesas-irqc: Remove unneeded inclusion of
 <linux/spinlock.h>

On Mon, Apr 29, 2019 at 05:20:02PM +0200, Geert Uytterhoeven wrote:
> The driver never used spinlocks, and thus does not need to include
> <linux/spinlock.h>.
> 
> Signed-off-by: Geert Uytterhoeven <geert+renesas@...der.be>

Reviewed-by: Simon Horman <horms+renesas@...ge.net.au>

> ---
>  drivers/irqchip/irq-renesas-irqc.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/irqchip/irq-renesas-irqc.c b/drivers/irqchip/irq-renesas-irqc.c
> index a449a7c839b3ec08..438a063c76156d98 100644
> --- a/drivers/irqchip/irq-renesas-irqc.c
> +++ b/drivers/irqchip/irq-renesas-irqc.c
> @@ -7,7 +7,6 @@
>  
>  #include <linux/init.h>
>  #include <linux/platform_device.h>
> -#include <linux/spinlock.h>
>  #include <linux/interrupt.h>
>  #include <linux/ioport.h>
>  #include <linux/io.h>
> -- 
> 2.17.1
>