linux-kernel - Re: [PATCH v2] drm/stm: ltdc: remove clk_round

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <317f94d6-846f-92e2-bd0f-b44377ea7845@st.com>
Date:   Mon, 13 May 2019 14:45:58 +0000
From:   Philippe CORNU <philippe.cornu@...com>
To:     Yannick FERTRE <yannick.fertre@...com>,
        Benjamin GAIGNARD <benjamin.gaignard@...com>,
        Vincent ABRIOU <vincent.abriou@...com>,
        "David Airlie" <airlied@...ux.ie>, Daniel Vetter <daniel@...ll.ch>,
        Maxime Coquelin <mcoquelin.stm32@...il.com>,
        Alexandre TORGUE <alexandre.torgue@...com>,
        "dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>,
        "linux-stm32@...md-mailman.stormreply.com" 
        <linux-stm32@...md-mailman.stormreply.com>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] drm/stm: ltdc: remove clk_round_rate comment

Dear Yannick,

Acked-by: Philippe Cornu <philippe.cornu@...com>

Thank you,

Philippe :-)

On 5/13/19 3:15 PM, Yannick Fertré wrote:
> Clk_round_rate returns rounded clock without changing
> the hardware in any way.
> This function couldn't replace set_rate/get_rate calls.
> Todo comment has been removed & a new log inserted.
> 
> Signed-off-by: Yannick Fertré <yannick.fertre@...com>
> ---
> Changes in v2:
> 	- Clk_enable & clk_disable are needed for the SOC STM32F7
> 	 (not for STM32MP1). I return this part of the patch to make sure the
> 	 driver is compatible with all SOC STM32.
> 
>   drivers/gpu/drm/stm/ltdc.c | 8 +++-----
>   1 file changed, 3 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/gpu/drm/stm/ltdc.c b/drivers/gpu/drm/stm/ltdc.c
> index 97912e2..1104e78 100644
> --- a/drivers/gpu/drm/stm/ltdc.c
> +++ b/drivers/gpu/drm/stm/ltdc.c
> @@ -507,11 +507,6 @@ static bool ltdc_crtc_mode_fixup(struct drm_crtc *crtc,
>   	struct ltdc_device *ldev = crtc_to_ltdc(crtc);
>   	int rate = mode->clock * 1000;
> 
> -	/*
> -	 * TODO clk_round_rate() does not work yet. When ready, it can
> -	 * be used instead of clk_set_rate() then clk_get_rate().
> -	 */
> -
>   	clk_disable(ldev->pixel_clk);
>   	if (clk_set_rate(ldev->pixel_clk, rate) < 0) {
>   		DRM_ERROR("Cannot set rate (%dHz) for pixel clk\n", rate);
> @@ -521,6 +516,9 @@ static bool ltdc_crtc_mode_fixup(struct drm_crtc *crtc,
> 
>   	adjusted_mode->clock = clk_get_rate(ldev->pixel_clk) / 1000;
> 
> +	DRM_DEBUG_DRIVER("requested clock %dkHz, adjusted clock %dkHz\n",
> +			 mode->clock, adjusted_mode->clock);
> +
>   	return true;
>   }
> 
> --
> 2.7.4
>