linux-kernel - Re: [PATCH] drm/panfrost: Only put sync

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAL_JsqJ9wd73i+zc4bnF4CdC_2Aa9u7xN1PQTUNbaaT=i1BVqg@mail.gmail.com>
Date:   Mon, 13 May 2019 09:56:18 -0500
From:   Rob Herring <robh@...nel.org>
To:     Tomeu Vizoso <tomeu.vizoso@...labora.com>
Cc:     LKML <linux-kernel@...r.kernel.org>,
        Dan Carpenter <dan.carpenter@...cle.com>,
        David Airlie <airlied@...ux.ie>,
        Daniel Vetter <daniel@...ll.ch>,
        dri-devel <dri-devel@...ts.freedesktop.org>
Subject: Re: [PATCH] drm/panfrost: Only put sync_out if non-NULL

On Thu, May 9, 2019 at 3:22 AM Tomeu Vizoso <tomeu.vizoso@...labora.com> wrote:
>
> Dan Carpenter's static analysis tool reported:
>
> drivers/gpu/drm/panfrost/panfrost_drv.c:222 panfrost_ioctl_submit()
> error: we previously assumed 'sync_out' could be null (see line 216)
>
> Indeed, sync_out could be NULL if userspace doesn't send a sync object
> ID for the out fence.
>
> Signed-off-by: Tomeu Vizoso <tomeu.vizoso@...labora.com>
> Reported-by: Dan Carpenter <dan.carpenter@...cle.com>
> Link: https://lists.freedesktop.org/archives/dri-devel/2019-May/217014.html
> ---
>  drivers/gpu/drm/panfrost/panfrost_drv.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)

Applied.

Rob