linux-kernel - Re: [PATCH v3 15/30] coresight: Make sure device uses DT for obsolete compatible check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190513161832.GA16162@xps15>
Date:   Mon, 13 May 2019 10:18:32 -0600
From:   Mathieu Poirier <mathieu.poirier@...aro.org>
To:     Suzuki K Poulose <suzuki.poulose@....com>
Cc:     linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        coresight@...ts.linaro.org, rjw@...ysocki.net,
        Leo Yan <leo.yan@...aro.org>
Subject: Re: [PATCH v3 15/30] coresight: Make sure device uses DT for
 obsolete compatible check

On Tue, May 07, 2019 at 11:52:42AM +0100, Suzuki K Poulose wrote:
> As we prepare to add support for ACPI bindings, let us make sure we do
> the compatible check only if we are sure we are dealing with a DT based
> system.
> 
> Cc: Leo Yan <leo.yan@...aro.org>
> Cc: Mathieu Poirier <mathieu.poirier@...aro.org>
> Signed-off-by: Suzuki K Poulose <suzuki.poulose@....com>
> ---
>  drivers/hwtracing/coresight/coresight-funnel.c     | 3 ++-
>  drivers/hwtracing/coresight/coresight-replicator.c | 3 ++-
>  2 files changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/hwtracing/coresight/coresight-funnel.c b/drivers/hwtracing/coresight/coresight-funnel.c
> index 6236a84..3423042 100644
> --- a/drivers/hwtracing/coresight/coresight-funnel.c
> +++ b/drivers/hwtracing/coresight/coresight-funnel.c
> @@ -196,7 +196,8 @@ static int funnel_probe(struct device *dev, struct resource *res)
>  		dev->platform_data = pdata;
>  	}
>  
> -	if (of_device_is_compatible(np, "arm,coresight-funnel"))
> +	if (is_of_node(dev_fwnode(dev)) &&
> +	    of_device_is_compatible(dev->of_node, "arm,coresight-funnel"))
>  		pr_warn_once("Uses OBSOLETE CoreSight funnel binding\n");
>  
>  	drvdata = devm_kzalloc(dev, sizeof(*drvdata), GFP_KERNEL);
> diff --git a/drivers/hwtracing/coresight/coresight-replicator.c b/drivers/hwtracing/coresight/coresight-replicator.c
> index ee6ad34..7e05145 100644
> --- a/drivers/hwtracing/coresight/coresight-replicator.c
> +++ b/drivers/hwtracing/coresight/coresight-replicator.c
> @@ -187,7 +187,8 @@ static int replicator_probe(struct device *dev, struct resource *res)
>  		dev->platform_data = pdata;
>  	}
>  
> -	if (of_device_is_compatible(np, "arm,coresight-replicator"))
> +	if (is_of_node(dev_fwnode(dev)) &&
> +	    of_device_is_compatible(dev->of_node, "arm,coresight-replicator"))
>  		pr_warn_once("Uses OBSOLETE CoreSight replicator binding\n");

Reviewed-by: Mathieu Poirier <mathieu.poirier@...aro.org>

>  
>  	drvdata = devm_kzalloc(dev, sizeof(*drvdata), GFP_KERNEL);
> -- 
> 2.7.4
>