linux-kernel - Re: [PATCH v1 4/8] soc/fsl/qbman: Use index when accessing device tree properties

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 13 May 2019 16:40:36 +0000
From:   Joakim Tjernlund <Joakim.Tjernlund@...inera.com>
To:     "linuxppc-dev@...ts.ozlabs.org" <linuxppc-dev@...ts.ozlabs.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "leoyang.li@....com" <leoyang.li@....com>,
        "roy.pledge@....com" <roy.pledge@....com>
CC:     "madalin.bucur@....com" <madalin.bucur@....com>,
        "laurentiu.tudor@....com" <laurentiu.tudor@....com>
Subject: Re: [PATCH v1 4/8] soc/fsl/qbman: Use index when accessing device
 tree properties

On Mon, 2019-05-13 at 16:09 +0000, Roy Pledge wrote:
> 
> The index value should be passed to the of_parse_phandle()
> function to ensure the correct property is read.

Is this a bug fix? Maybe for stable too?

 Jocke

> 
> Signed-off-by: Roy Pledge <roy.pledge@....com>
> ---
>  drivers/soc/fsl/qbman/dpaa_sys.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/soc/fsl/qbman/dpaa_sys.c b/drivers/soc/fsl/qbman/dpaa_sys.c
> index 3e0a7f3..0b901a8 100644
> --- a/drivers/soc/fsl/qbman/dpaa_sys.c
> +++ b/drivers/soc/fsl/qbman/dpaa_sys.c
> @@ -49,7 +49,7 @@ int qbman_init_private_mem(struct device *dev, int idx, dma_addr_t *addr,
>                         idx, ret);
>                 return -ENODEV;
>         }
> -       mem_node = of_parse_phandle(dev->of_node, "memory-region", 0);
> +       mem_node = of_parse_phandle(dev->of_node, "memory-region", idx);
>         if (mem_node) {
>                 ret = of_property_read_u64(mem_node, "size", &size64);
>                 if (ret) {
> --
> 2.7.4
>