linux-kernel - Re: [PATCH 2/3] KVM: LAPIC: Fix lapic_timer_advance

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190513191441.GK28561@linux.intel.com>
Date:   Mon, 13 May 2019 12:14:41 -0700
From:   Sean Christopherson <sean.j.christopherson@...el.com>
To:     Wanpeng Li <kernellwp@...il.com>
Cc:     linux-kernel@...r.kernel.org, kvm@...r.kernel.org,
        Paolo Bonzini <pbonzini@...hat.com>,
        Radim Krčmář <rkrcmar@...hat.com>,
        Liran Alon <liran.alon@...cle.com>
Subject: Re: [PATCH 2/3] KVM: LAPIC: Fix lapic_timer_advance_ns parameter
 overflow

On Thu, May 09, 2019 at 07:29:20PM +0800, Wanpeng Li wrote:
> From: Wanpeng Li <wanpengli@...cent.com>
> 
> After commit c3941d9e0 (KVM: lapic: Allow user to disable adaptive tuning of 
> timer advancement), '-1' enables adaptive tuning starting from default 
> advancment of 1000ns. However, we should expose an int instead of an overflow 
> uint module parameter.
> 
> Before patch:
> 
> /sys/module/kvm/parameters/lapic_timer_advance_ns:4294967295
> 
> After patch:
> 
> /sys/module/kvm/parameters/lapic_timer_advance_ns:-1
> 
> Fixes: c3941d9e0 (KVM: lapic: Allow user to disable adaptive tuning of timer advancement)
> Cc: Paolo Bonzini <pbonzini@...hat.com>
> Cc: Radim Krčmář <rkrcmar@...hat.com>
> Cc: Sean Christopherson <sean.j.christopherson@...el.com>
> Cc: Liran Alon <liran.alon@...cle.com>
> Signed-off-by: Wanpeng Li <wanpengli@...cent.com>
> ---

Reviewed-by: Sean Christopherson <sean.j.christopherson@...el.com>