lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 13 May 2019 23:45:03 +0200 From: Michal Hocko <mhocko@...nel.org> To: Yang Shi <yang.shi@...ux.alibaba.com> Cc: ying.huang@...el.com, hannes@...xchg.org, mgorman@...hsingularity.net, kirill.shutemov@...ux.intel.com, hughd@...gle.com, shakeelb@...gle.com, william.kucharski@...cle.com, akpm@...ux-foundation.org, linux-mm@...ck.org, linux-kernel@...r.kernel.org Subject: Re: [v2 PATCH] mm: vmscan: correct nr_reclaimed for THP On Mon 13-05-19 14:09:59, Yang Shi wrote: [...] > I think we can just account 512 base pages for nr_scanned for > isolate_lru_pages() to make the counters sane since PGSCAN_KSWAPD/DIRECT > just use it. > > And, sc->nr_scanned should be accounted as 512 base pages too otherwise we > may have nr_scanned < nr_to_reclaim all the time to result in false-negative > for priority raise and something else wrong (e.g. wrong vmpressure). Be careful. nr_scanned is used as a pressure indicator to slab shrinking AFAIR. Maybe this is ok but it really begs for much more explaining than "it should be fine". This should have happened when THP swap out was implemented... -- Michal Hocko SUSE Labs
Powered by blists - more mailing lists