linux-kernel - Re: [PATCH 1/2] firmware: bcm47xx_nvram: Correct size

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ffbff01f239ec468af0b591638e019f3f8fc990e.camel@perches.com>
Date:   Mon, 13 May 2019 14:57:45 -0700
From:   Joe Perches <joe@...ches.com>
To:     Florian Fainelli <f.fainelli@...il.com>, linux-mips@...ux-mips.org
Cc:     Rafał Miłecki <zajec5@...il.com>,
        "open list:BROADCOM NVRAM DRIVER" <linux-mips@...r.kernel.org>,
        open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/2] firmware: bcm47xx_nvram: Correct size_t printf
 format

On Mon, 2019-05-13 at 14:52 -0700, Florian Fainelli wrote:
> When building on a 64-bit host, we will get warnings like those:
> 
> drivers/firmware/broadcom/bcm47xx_nvram.c:103:3: note: in expansion of macro 'pr_err'
>    pr_err("nvram on flash (%i bytes) is bigger than the reserved space in memory, will just copy the first %i bytes\n",
>    ^~~~~~
> drivers/firmware/broadcom/bcm47xx_nvram.c:103:28: note: format string is defined here
>    pr_err("nvram on flash (%i bytes) is bigger than the reserved space in memory, will just copy the first %i bytes\n",
>                            ~^
>                            %li
> 
> Use %zi instead for that purpose.

typically it is %zu