linux-kernel - Re: [PATCH] perf vendor events intel: Add uncore

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <23EB4484-49C2-47CE-BE31-1E83DBA29B87@kernel.org>
Date:   Mon, 13 May 2019 19:05:12 -0300
From:   Arnaldo Carvalho de Melo <arnaldo.melo@...il.com>
To:     "Liang, Kan" <kan.liang@...ux.intel.com>, jolsa@...nel.org,
        mingo@...hat.com, linux-kernel@...r.kernel.org
CC:     ak@...ux.intel.com
Subject: Re: [PATCH] perf vendor events intel: Add uncore_upi JSON support

On May 13, 2019 6:29:30 PM GMT-03:00, "Liang, Kan" <kan.liang@...ux.intel.com> wrote:
>Hi Arnaldo,
>
>Could you please apply this fix?

I think I merged this today, will check.

Thanks

- Arnaldo
>
>Thanks,
>Kan
>
>On 5/7/2019 9:16 AM, kan.liang@...ux.intel.com wrote:
>> From: Kan Liang <kan.liang@...ux.intel.com>
>> 
>> Perf cannot parse UPI events.
>> 
>>      #perf stat -e UPI_DATA_BANDWIDTH_TX
>>      event syntax error: 'UPI_DATA_BANDWIDTH_TX'
>>                       \___ parser error
>>      Run 'perf list' for a list of valid events
>> 
>> The JSON lists call the box UPI LL, while perf calls it upi.
>> Add conversion support to json to convert the unit properly.
>> 
>> Signed-off-by: Kan Liang <kan.liang@...ux.intel.com>
>> ---
>>   tools/perf/pmu-events/jevents.c | 1 +
>>   1 file changed, 1 insertion(+)
>> 
>> diff --git a/tools/perf/pmu-events/jevents.c
>b/tools/perf/pmu-events/jevents.c
>> index 68c92bb..daaea50 100644
>> --- a/tools/perf/pmu-events/jevents.c
>> +++ b/tools/perf/pmu-events/jevents.c
>> @@ -235,6 +235,7 @@ static struct map {
>>   	{ "iMPH-U", "uncore_arb" },
>>   	{ "CPU-M-CF", "cpum_cf" },
>>   	{ "CPU-M-SF", "cpum_sf" },
>> +	{ "UPI LL", "uncore_upi" },
>>   	{}
>>   };
>>   
>>