linux-kernel - Re: [PATCH] drm/bridge: Remove duplicate header

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190514073542.GA4969@pendragon.ideasonboard.com>
Date:   Tue, 14 May 2019 10:35:42 +0300
From:   Laurent Pinchart <laurent.pinchart@...asonboard.com>
To:     Sabyasachi Gupta <sabyasachi.linux@...il.com>
Cc:     architt@...eaurora.org, a.hajda@...sung.com, airlied@...ux.ie,
        jrdr.linux@...il.com, dri-devel@...ts.freedesktop.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drm/bridge: Remove duplicate header

Hi Sabyasachi,

Thank you for the patch.

On Tue, May 14, 2019 at 01:01:41PM +0530, Sabyasachi Gupta wrote:
> Remove drm/drm_panel.h which is included more than once
> 
> Signed-off-by: Sabyasachi Gupta <sabyasachi.linux@...il.com>
> ---
>  drivers/gpu/drm/bridge/panel.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/bridge/panel.c b/drivers/gpu/drm/bridge/panel.c
> index 7cbaba2..402b318 100644
> --- a/drivers/gpu/drm/bridge/panel.c
> +++ b/drivers/gpu/drm/bridge/panel.c
> @@ -15,7 +15,6 @@
>  #include <drm/drm_crtc_helper.h>
>  #include <drm/drm_encoder.h>
>  #include <drm/drm_modeset_helper_vtables.h>
> -#include <drm/drm_panel.h>

Which tree is this against ? The patch applies on neither drm-next nor
drm-misc-next.

While at it, could you you reorder the other header alphabetically to
make this kind of issue easier to notice ?

>  
>  struct panel_bridge {
>  	struct drm_bridge bridge;

-- 
Regards,

Laurent Pinchart