linux-kernel - Re: [PATCH RESEND 1/2] soc: imx: Add SCU SoC info driver support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 14 May 2019 11:38:51 +0300
From:   Daniel Baluta <daniel.baluta@...il.com>
To:     Anson Huang <anson.huang@....com>
Cc:     "catalin.marinas@....com" <catalin.marinas@....com>,
        "will.deacon@....com" <will.deacon@....com>,
        "shawnguo@...nel.org" <shawnguo@...nel.org>,
        "s.hauer@...gutronix.de" <s.hauer@...gutronix.de>,
        "kernel@...gutronix.de" <kernel@...gutronix.de>,
        "festevam@...il.com" <festevam@...il.com>,
        "maxime.ripard@...tlin.com" <maxime.ripard@...tlin.com>,
        "agross@...nel.org" <agross@...nel.org>,
        "olof@...om.net" <olof@...om.net>,
        "horms+renesas@...ge.net.au" <horms+renesas@...ge.net.au>,
        "jagan@...rulasolutions.com" <jagan@...rulasolutions.com>,
        "bjorn.andersson@...aro.org" <bjorn.andersson@...aro.org>,
        Leonard Crestez <leonard.crestez@....com>,
        "marc.w.gonzalez@...e.fr" <marc.w.gonzalez@...e.fr>,
        "dinguyen@...nel.org" <dinguyen@...nel.org>,
        "enric.balletbo@...labora.com" <enric.balletbo@...labora.com>,
        Aisheng Dong <aisheng.dong@....com>,
        "robh@...nel.org" <robh@...nel.org>, Abel Vesa <abel.vesa@....com>,
        "l.stach@...gutronix.de" <l.stach@...gutronix.de>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        dl-linux-imx <linux-imx@....com>,
        Daniel Baluta <daniel.baluta@....com>
Subject: Re: [PATCH RESEND 1/2] soc: imx: Add SCU SoC info driver support

On Tue, May 14, 2019 at 2:34 AM Anson Huang <anson.huang@....com> wrote:
>
> Hi, Daniel
>
> > -----Original Message-----
> > From: Daniel Baluta [mailto:daniel.baluta@...il.com]
> > Sent: Monday, May 13, 2019 10:30 PM
> > To: Anson Huang <anson.huang@....com>
> > Cc: catalin.marinas@....com; will.deacon@....com;
> > shawnguo@...nel.org; s.hauer@...gutronix.de; kernel@...gutronix.de;
> > festevam@...il.com; maxime.ripard@...tlin.com; agross@...nel.org;
> > olof@...om.net; horms+renesas@...ge.net.au;
> > jagan@...rulasolutions.com; bjorn.andersson@...aro.org; Leonard Crestez
> > <leonard.crestez@....com>; marc.w.gonzalez@...e.fr;
> > dinguyen@...nel.org; enric.balletbo@...labora.com; Aisheng Dong
> > <aisheng.dong@....com>; robh@...nel.org; Abel Vesa
> > <abel.vesa@....com>; l.stach@...gutronix.de; linux-arm-
> > kernel@...ts.infradead.org; linux-kernel@...r.kernel.org; dl-linux-imx
> > <linux-imx@....com>; Daniel Baluta <daniel.baluta@....com>
> > Subject: Re: [PATCH RESEND 1/2] soc: imx: Add SCU SoC info driver support
> >
> > <snip>
> >
> > > +
> > > +static u32 imx8qxp_soc_revision(void) {
> > > +       struct imx_sc_msg_misc_get_soc_id msg;
> > > +       struct imx_sc_rpc_msg *hdr = &msg.hdr;
> > > +       u32 rev = 0;
> > > +       int ret;
> > > +
> > > +       hdr->ver = IMX_SC_RPC_VERSION;
> > > +       hdr->svc = IMX_SC_RPC_SVC_MISC;
> > > +       hdr->func = IMX_SC_MISC_FUNC_GET_CONTROL;
> > > +       hdr->size = 3;
> > > +
> > > +       msg.data.send.control = IMX_SC_C_ID;
> > > +       msg.data.send.resource = IMX_SC_R_SYSTEM;
> > > +
> > > +       ret = imx_scu_call_rpc(soc_ipc_handle, &msg, true);
> > > +       if (ret) {
> > > +               dev_err(&imx_scu_soc_pdev->dev,
> > > +                       "get soc info failed, ret %d\n", ret);
> > > +               return rev;
> >
> > So you return 0 (rev  = 0) here in case of error? This doesn't seem to be right.
> > Maybe return ret?
>
> This is intentional, similar with current i.MX8MQ soc info driver, when getting revision
> failed, just return 0 as revision info and it will show "unknown" in sysfs.

Ok, I understand. Lets make this clear from the source code.

   ret = imx_scu_call_rpc(soc_ipc_handle, &msg, true);
+       if (ret) {
+               dev_err(&imx_scu_soc_pdev->dev,
+                       "get soc info failed, ret %d\n", ret);
                /* returning 0 means getting revision failed */
+               return 0;
+       }