linux-kernel - Re: [PATCH] scsi: smartpqi: Reporting unhandled SCSI errors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <yq1imudg9nx.fsf@oracle.com>
Date:   Mon, 13 May 2019 20:30:10 -0400
From:   "Martin K. Petersen" <martin.petersen@...cle.com>
To:     <Don.Brace@...rochip.com>
Cc:     <erwanaliasr1@...il.com>, <e.velu@...teo.com>,
        <don.brace@...rosemi.com>, <jejb@...ux.ibm.com>,
        <martin.petersen@...cle.com>, <esc.storagedev@...rosemi.com>,
        <linux-scsi@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] scsi: smartpqi: Reporting unhandled SCSI errors


>> When a HARDWARE_ERROR is triggered for asc=0x3e, the actual code is
>> only considering the case where ascq=0x1.
>>
>> Following the http://www.t10.org/lists/asc-num.htm#ASC_3E
>> specification, other values may occur like a timeout (ascq=0x2).
>>
>> This patch is about printing an error message when a non-handled
>> message is received.  This could help diagnose a possible
>> miss-behavior of the controller and/or a missing implementation in
>> the Linux Kernel.
>>
>> This patch keeps the exact same error handling but prints a message
>> if an ascq != 1 income.
>>
>> Signed-off-by: Erwan Velu <e.velu@...teo.com>
> Acked-by: Don Brace <don.brace@...rosemi.com>

Applied to 5.2/scsi-queue. Thanks!

-- 
Martin K. Petersen	Oracle Linux Engineering