| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <3c82f3e0-999c-b389-aa9b-f06919800bb4@infradead.org>
Date: Tue, 14 May 2019 07:24:38 -0700
From: Randy Dunlap <rdunlap@...radead.org>
To: Ricardo Neri <ricardo.neri-calderon@...ux.intel.com>,
Thomas Gleixner <tglx@...utronix.de>,
Ingo Molnar <mingo@...nel.org>, Borislav Petkov <bp@...e.de>
Cc: Ashok Raj <ashok.raj@...el.com>, Joerg Roedel <joro@...tes.org>,
Andi Kleen <andi.kleen@...el.com>,
Peter Zijlstra <peterz@...radead.org>,
"Ravi V. Shankar" <ravi.v.shankar@...el.com>, x86@...nel.org,
linux-kernel@...r.kernel.org, iommu@...ts.linux-foundation.org,
Ricardo Neri <ricardo.neri@...el.com>,
"H. Peter Anvin" <hpa@...or.com>, Tony Luck <tony.luck@...el.com>,
Philippe Ombredanne <pombredanne@...b.com>,
Kate Stewart <kstewart@...uxfoundation.org>,
"Rafael J. Wysocki" <rafael.j.wysocki@...el.com>,
Stephane Eranian <eranian@...gle.com>,
Suravee Suthikulpanit <Suravee.Suthikulpanit@....com>
Subject: Re: [RFC PATCH v3 04/21] x86/hpet: Add hpet_set_comparator() for
periodic and one-shot modes
On 5/14/19 7:01 AM, Ricardo Neri wrote:
> Instead of setting the timer period directly in hpet_set_periodic(), add a
> new helper function hpet_set_comparator() that only sets the accumulator
> and comparator. hpet_set_periodic() will only prepare the timer for
> periodic mode and leave the expiration programming to
> hpet_set_comparator().
>
> This new function can also be used by other components (e.g., the HPET-
> based hardlockup detector) which also need to configure HPET timers. Thus,
> add its declaration into the hpet header file.
>
> Cc: "H. Peter Anvin" <hpa@...or.com>
> Cc: Ashok Raj <ashok.raj@...el.com>
> Cc: Andi Kleen <andi.kleen@...el.com>
> Cc: Tony Luck <tony.luck@...el.com>
> Cc: Philippe Ombredanne <pombredanne@...b.com>
> Cc: Kate Stewart <kstewart@...uxfoundation.org>
> Cc: "Rafael J. Wysocki" <rafael.j.wysocki@...el.com>
> Cc: Stephane Eranian <eranian@...gle.com>
> Cc: Suravee Suthikulpanit <Suravee.Suthikulpanit@....com>
> Cc: "Ravi V. Shankar" <ravi.v.shankar@...el.com>
> Cc: x86@...nel.org
> Originally-by: Suravee Suthikulpanit <Suravee.Suthikulpanit@....com>
> Signed-off-by: Ricardo Neri <ricardo.neri-calderon@...ux.intel.com>
> ---
> arch/x86/include/asm/hpet.h | 1 +
> arch/x86/kernel/hpet.c | 57 ++++++++++++++++++++++++++++---------
> 2 files changed, 45 insertions(+), 13 deletions(-)
>
> diff --git a/arch/x86/include/asm/hpet.h b/arch/x86/include/asm/hpet.h
> index f132fbf984d4..e7098740f5ee 100644
> --- a/arch/x86/include/asm/hpet.h
> +++ b/arch/x86/include/asm/hpet.h
> @@ -102,6 +102,7 @@ extern int hpet_rtc_timer_init(void);
> extern irqreturn_t hpet_rtc_interrupt(int irq, void *dev_id);
> extern int hpet_register_irq_handler(rtc_irq_handler handler);
> extern void hpet_unregister_irq_handler(rtc_irq_handler handler);
> +extern void hpet_set_comparator(int num, unsigned int cmp, unsigned int period);
>
> #endif /* CONFIG_HPET_EMULATE_RTC */
>
> diff --git a/arch/x86/kernel/hpet.c b/arch/x86/kernel/hpet.c
> index 560fc28e1d13..c5c5fc150193 100644
> --- a/arch/x86/kernel/hpet.c
> +++ b/arch/x86/kernel/hpet.c
> @@ -289,6 +289,46 @@ static void hpet_legacy_clockevent_register(void)
> printk(KERN_DEBUG "hpet clockevent registered\n");
> }
>
> +/**
> + * hpet_set_comparator() - Helper function for setting comparator register
> + * @num: The timer ID
> + * @cmp: The value to be written to the comparator/accumulator
> + * @period: The value to be written to the period (0 = oneshot mode)
> + *
> + * Helper function for updating comparator, accumulator and period values.
> + *
> + * In periodic mode, HPET needs HPET_TN_SETVAL to be set before writing
> + * to the Tn_CMP to update the accumulator. Then, HPET needs a second
> + * write (with HPET_TN_SETVAL cleared) to Tn_CMP to set the period.
> + * The HPET_TN_SETVAL bit is automatically cleared after the first write.
> + *
> + * For one-shot mode, HPET_TN_SETVAL does not need to be set.
> + *
> + * See the following documents:
> + * - Intel IA-PC HPET (High Precision Event Timers) Specification
> + * - AMD-8111 HyperTransport I/O Hub Data Sheet, Publication # 24674
> + */
> +void hpet_set_comparator(int num, unsigned int cmp, unsigned int period)
> +{
> + if (period) {
> + unsigned int v = hpet_readl(HPET_Tn_CFG(num));
> +
> + hpet_writel(v | HPET_TN_SETVAL, HPET_Tn_CFG(num));
> + }
> +
> + hpet_writel(cmp, HPET_Tn_CMP(num));
> +
> + if (!period)
> + return;
> +
> + /* This delay is seldom used: never in one-shot mode and in periodic
> + * only when reprogramming the timer.
> + */
comment style warning ;)
> + udelay(1);
> + hpet_writel(period, HPET_Tn_CMP(num));
> +}
> +EXPORT_SYMBOL_GPL(hpet_set_comparator);
> +
> static int hpet_set_periodic(struct clock_event_device *evt, int timer)
> {
> unsigned int cfg, cmp, now;
> @@ -300,19 +340,10 @@ static int hpet_set_periodic(struct clock_event_device *evt, int timer)
> now = hpet_readl(HPET_COUNTER);
> cmp = now + (unsigned int)delta;
> cfg = hpet_readl(HPET_Tn_CFG(timer));
> - cfg |= HPET_TN_ENABLE | HPET_TN_PERIODIC | HPET_TN_SETVAL |
> - HPET_TN_32BIT;
> - hpet_writel(cfg, HPET_Tn_CFG(timer));
> - hpet_writel(cmp, HPET_Tn_CMP(timer));
> - udelay(1);
> - /*
> - * HPET on AMD 81xx needs a second write (with HPET_TN_SETVAL
> - * cleared) to T0_CMP to set the period. The HPET_TN_SETVAL
> - * bit is automatically cleared after the first write.
> - * (See AMD-8111 HyperTransport I/O Hub Data Sheet,
> - * Publication # 24674)
> - */
> - hpet_writel((unsigned int)delta, HPET_Tn_CMP(timer));
> + cfg |= HPET_TN_ENABLE | HPET_TN_PERIODIC | HPET_TN_32BIT;
> +
> + hpet_set_comparator(timer, cmp, (unsigned int)delta);
> +
> hpet_start_counter();
> hpet_print_config();
>
>
--
~Randy
Powered by blists - more mailing lists