[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAJiuCccZvk_rHmh4Trt+1uG0APu886Zp_DvUwGcMkph0U0biAA@mail.gmail.com>
Date: Tue, 14 May 2019 17:22:46 +0200
From: Clément Péron <peron.clem@...il.com>
To: Chen-Yu Tsai <wens@...e.org>
Cc: David Airlie <airlied@...ux.ie>, Daniel Vetter <daniel@...ll.ch>,
Rob Herring <robh+dt@...nel.org>,
Mark Rutland <mark.rutland@....com>,
Maxime Ripard <maxime.ripard@...tlin.com>,
dri-devel <dri-devel@...ts.freedesktop.org>,
devicetree <devicetree@...r.kernel.org>,
linux-kernel <linux-kernel@...r.kernel.org>,
linux-arm-kernel <linux-arm-kernel@...ts.infradead.org>,
linux-sunxi <linux-sunxi@...glegroups.com>,
Jagan Teki <jagan@...rulasolutions.com>
Subject: Re: [linux-sunxi] [PATCH v4 5/8] arm64: dts: allwinner: Add mali GPU
supply for Pine H64
Hi Jagan, Chen-Yu,
On Tue, 14 May 2019 at 12:18, Chen-Yu Tsai <wens@...e.org> wrote:
>
> On Mon, May 13, 2019 at 2:28 AM Jagan Teki <jagan@...rulasolutions.com> wrote:
> >
> > On Sun, May 12, 2019 at 11:16 PM <peron.clem@...il.com> wrote:
> > >
> > > From: Clément Péron <peron.clem@...il.com>
> > >
> > > Enable and add supply to the Mali GPU node on the
> > > Pine H64 board.
> > >
> > > Signed-off-by: Clément Péron <peron.clem@...il.com>
> > > ---
> > > arch/arm64/boot/dts/allwinner/sun50i-h6-pine-h64.dts | 5 +++++
> > > 1 file changed, 5 insertions(+)
> > >
> > > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h6-pine-h64.dts b/arch/arm64/boot/dts/allwinner/sun50i-h6-pine-h64.dts
> > > index 4802902e128f..e16a8c6738f9 100644
> > > --- a/arch/arm64/boot/dts/allwinner/sun50i-h6-pine-h64.dts
> > > +++ b/arch/arm64/boot/dts/allwinner/sun50i-h6-pine-h64.dts
> > > @@ -85,6 +85,11 @@
> > > status = "okay";
> > > };
> > >
> > > +&gpu {
> > > + mali-supply = <®_dcdcc>;
> > > + status = "okay";
> > > +};
> >
> > I think we can squash all these board dts changes into single patch.
>
> Yes. Please do so for all patches with the same changes applied to different
> boards, and authored by the same person.
I thought it was required to have "smallest" patch as possible.
And it's also better for tracking "Tested-by" tag.
I will squash them in the next version.
Thanks,
Clement
>
> ChenYu
Powered by blists - more mailing lists