linux-kernel - Re: [PATCH v2] serial: sh-sci: disable DMA for uart

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190514153021.GC18528@mam-gdavis-lt>
Date:   Tue, 14 May 2019 11:30:22 -0400
From:   "George G. Davis" <george_davis@...tor.com>
To:     Geert Uytterhoeven <geert@...ux-m68k.org>
CC:     Eugeniu Rosca <erosca@...adit-jv.com>,
        Simon Horman <horms+renesas@...ge.net.au>,
        Wolfram Sang <wsa+renesas@...g-engineering.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Jiri Slaby <jslaby@...e.com>,
        "open list:SERIAL DRIVERS" <linux-serial@...r.kernel.org>,
        open list <linux-kernel@...r.kernel.org>,
        Chris Brandt <chris.brandt@...esas.com>,
        Ulrich Hecht <ulrich.hecht+renesas@...il.com>,
        Andy Lowe <andy_lowe@...tor.com>,
        Linux-Renesas <linux-renesas-soc@...r.kernel.org>,
        OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS 
        <devicetree@...r.kernel.org>, Magnus Damm <magnus.damm@...il.com>,
        Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        stable <stable@...r.kernel.org>
Subject: Re: [PATCH v2] serial: sh-sci: disable DMA for uart_console

Hello Geert,

On Tue, May 14, 2019 at 10:28:34AM +0200, Geert Uytterhoeven wrote:
> Hi George,
> 
> On Mon, May 13, 2019 at 5:48 PM George G. Davis <george_davis@...tor.com> wrote:
> > As noted in commit 84b40e3b57ee ("serial: 8250: omap: Disable DMA for
> > console UART"), UART console lines use low-level PIO only access functions
> > which will conflict with use of the line when DMA is enabled, e.g. when
> > the console line is also used for systemd messages. So disable DMA
> > support for UART console lines.
> >
> > Fixes: https://patchwork.kernel.org/patch/10929511/
> 
> I don't think this is an appropriate reference, as it points to a patch that
> was never applied.

I included it as a link to an upstream problem report similar to other commits
that I previewed. The link provides the extra context that I was perhaps to
lazy to note in the commit header.

> As the problem has basically existed forever,

Agreed

> IMHO no Fixes tag
> is needed.

I've dropped the Fixes line.

> > Reported-by: Michael Rodin <mrodin@...adit-jv.com>
> > Tested-by: Eugeniu Rosca <erosca@...adit-jv.com>
> > Reviewed-by: Simon Horman <horms+renesas@...ge.net.au>
> > Reviewed-by: Wolfram Sang <wsa+renesas@...g-engineering.com>
> > Cc: stable@...r.kernel.org
> > Signed-off-by: George G. Davis <george_davis@...tor.com>
> > ---
> > v2: Clarify comment regarding DMA support on kernel console,
> >     add {Tested,Reviewed}-by:, and Cc: linux-stable lines.
> 
> Thanks for the update!

Thanks!


I'll submit v3 later today.

> Reviewed-by: Geert Uytterhoeven <geert+renesas@...der.be>
> 
> Gr{oetje,eeting}s,
> 
>                         Geert
> 
> -- 
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org
> 
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
>                                 -- Linus Torvalds

-- 
Regards,
George