lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <bf389c60-1e47-80c1-43cc-9211a729b693@amd.com>
Date:   Tue, 14 May 2019 15:52:08 +0000
From:   "Suthikulpanit, Suravee" <Suravee.Suthikulpanit@....com>
To:     "Graf, Alexander" <graf@...zon.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "kvm@...r.kernel.org" <kvm@...r.kernel.org>
CC:     "pbonzini@...hat.com" <pbonzini@...hat.com>,
        "rkrcmar@...hat.com" <rkrcmar@...hat.com>,
        "joro@...tes.org" <joro@...tes.org>
Subject: Re: [PATCH] svm/avic: Do not send AVIC doorbell to self

Alex,

On 5/7/2019 8:16 AM, Graf, Alexander wrote:
> [CAUTION: External Email]
> 
> On 03.05.19 15:38, Suthikulpanit, Suravee wrote:
>> AVIC doorbell is used to notify a running vCPU that interrupts
>> has been injected into the vCPU AVIC backing page. Current logic
>> checks only if a VCPU is running before sending a doorbell.
>> However, the doorbell is not necessary if the destination
>> CPU is itself.
>>
>> Add logic to check currently running CPU before sending doorbell.
>>
>> Signed-off-by: Suravee Suthikulpanit <suravee.suthikulpanit@....com>
> 
> Reviewed-by: Alexander Graf <graf@...zon.com>

Thanks.

>> ---
>>   arch/x86/kvm/svm.c | 11 +++++++----
>>   1 file changed, 7 insertions(+), 4 deletions(-)
>>
>> diff --git a/arch/x86/kvm/svm.c b/arch/x86/kvm/svm.c
>> index 122788f..4bbf6fc 100644
>> --- a/arch/x86/kvm/svm.c
>> +++ b/arch/x86/kvm/svm.c
>> @@ -5283,10 +5283,13 @@ static void svm_deliver_avic_intr(struct kvm_vcpu *vcpu, int vec)
>>       kvm_lapic_set_irr(vec, vcpu->arch.apic);
>>       smp_mb__after_atomic();
>>
>> -     if (avic_vcpu_is_running(vcpu))
>> -             wrmsrl(SVM_AVIC_DOORBELL,
>> -                    kvm_cpu_get_apicid(vcpu->cpu));
>> -     else
>> +     if (avic_vcpu_is_running(vcpu)) { > +           int cpuid = vcpu->cpu;
>> +
>> +             if (cpuid != get_cpu())
> 
> Tiny nitpick: What would keep you from checking vcpu->cpu directly here?

Nothing. Just coding style.

Thanks,
Suravee

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ