linux-kernel - Re: [PATCH 1/2] of/fdt: Remove dead code and mark functions with _

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 14 May 2019 13:21:51 -0700
From:   Stephen Boyd <swboyd@...omium.org>
To:     Rob Herring <robh+dt@...nel.org>
Cc:     Frank Rowand <frowand.list@...il.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        devicetree@...r.kernel.org, Hsin-Yi Wang <hsinyi@...omium.org>
Subject: Re: [PATCH 1/2] of/fdt: Remove dead code and mark functions with __init

Quoting Rob Herring (2019-05-14 10:06:48)
> On Thu, May 9, 2019 at 4:55 PM Stephen Boyd <swboyd@...omium.org> wrote:
> > diff --git a/Documentation/devicetree/bindings/common-properties.txt b/Documentation/devicetree/bindings/common-properties.txt
> > index a3448bfa1c82..1c50d8700ab5 100644
> > --- a/Documentation/devicetree/bindings/common-properties.txt
> > +++ b/Documentation/devicetree/bindings/common-properties.txt
> > @@ -25,8 +25,8 @@ Optional properties:
> >  If a binding supports these properties, then the binding should also
> >  specify the default behavior if none of these properties are present.
> >  In such cases, little-endian is the preferred default, but it is not
> > -a requirement.  The of_device_is_big_endian() and of_fdt_is_big_endian()
> > -helper functions do assume that little-endian is the default, because
> > +a requirement.  The of_device_is_big_endian()
> 
> Hum, we shouldn't have kernel functions in binding docs. Can you
> reword to remove both functions.
> 

Ok. I'll resend with this sentence cleaned up more.