linux-kernel - Re: [PATCH net RESEND] net: macb: fix error format in dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 14 May 2019 15:41:29 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     luca@...aceresoli.net
Cc:     netdev@...r.kernel.org, nicolas.ferre@...rochip.com,
        linux-kernel@...r.kernel.org, andrew@...n.ch,
        soren.brinkmann@...inx.com, cyrille.pitchen@...el.com,
        shubhrajyoti.datta@...inx.com, harini.katakam@...inx.com
Subject: Re: [PATCH net RESEND] net: macb: fix error format in dev_err()

From: Luca Ceresoli <luca@...aceresoli.net>
Date: Tue, 14 May 2019 15:23:07 +0200

> Errors are negative numbers. Using %u shows them as very large positive
> numbers such as 4294967277 that don't make sense. Use the %d format
> instead, and get a much nicer -19.
> 
> Signed-off-by: Luca Ceresoli <luca@...aceresoli.net>
> Fixes: b48e0bab142f ("net: macb: Migrate to devm clock interface")
> Fixes: 93b31f48b3ba ("net/macb: unify clock management")
> Fixes: 421d9df0628b ("net/macb: merge at91_ether driver into macb driver")
> Fixes: aead88bd0e99 ("net: ethernet: macb: Add support for rx_clk")
> Fixes: f5473d1d44e4 ("net: macb: Support clock management for tsu_clk")
> Acked-by: Nicolas Ferre <nicolas.ferre@...rochip.com>
> Reviewed-by: Andrew Lunn <andrew@...n.ch>

Applied.