linux-kernel - Re: [PATCH] atm: iphase: Avoid copying pointers to user space.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20190514.160155.2039400951466133948.davem@davemloft.net>
Date:   Tue, 14 May 2019 16:01:55 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     huangfq.daxian@...il.com
Cc:     3chas3@...il.com, linux-atm-general@...ts.sourceforge.net,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] atm: iphase: Avoid copying pointers to user space.

From: Fuqian Huang <huangfq.daxian@...il.com>
Date: Tue, 14 May 2019 23:11:59 +0800

> When ia_cmds.sub_cmd is MEMDUMP_DEV in ia_ioctl,
> nullify the pointer fields of iadev before copying
> the whole structure to user space.
> 
> Signed-off-by: Fuqian Huang <huangfq.daxian@...il.com>

Honestly I'd rather you just remove the MEMDUMP_DEV ioctl altogether,
there is now ay that information is useful in any way whatsoever.

Thank you.