linux-kernel - RE: [PATCH V2 1/2] soc: imx: Add SCU SoC info driver support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <DB3PR0402MB3916FA535853AE7C0438FF8AF5090@DB3PR0402MB3916.eurprd04.prod.outlook.com>
Date:   Wed, 15 May 2019 11:56:23 +0000
From:   Anson Huang <anson.huang@....com>
To:     Daniel Baluta <daniel.baluta@...il.com>
CC:     "catalin.marinas@....com" <catalin.marinas@....com>,
        "will.deacon@....com" <will.deacon@....com>,
        "shawnguo@...nel.org" <shawnguo@...nel.org>,
        "s.hauer@...gutronix.de" <s.hauer@...gutronix.de>,
        "kernel@...gutronix.de" <kernel@...gutronix.de>,
        "festevam@...il.com" <festevam@...il.com>,
        "agross@...nel.org" <agross@...nel.org>,
        "maxime.ripard@...tlin.com" <maxime.ripard@...tlin.com>,
        "olof@...om.net" <olof@...om.net>,
        "horms+renesas@...ge.net.au" <horms+renesas@...ge.net.au>,
        "jagan@...rulasolutions.com" <jagan@...rulasolutions.com>,
        "bjorn.andersson@...aro.org" <bjorn.andersson@...aro.org>,
        Leonard Crestez <leonard.crestez@....com>,
        "marc.w.gonzalez@...e.fr" <marc.w.gonzalez@...e.fr>,
        "dinguyen@...nel.org" <dinguyen@...nel.org>,
        "enric.balletbo@...labora.com" <enric.balletbo@...labora.com>,
        "l.stach@...gutronix.de" <l.stach@...gutronix.de>,
        Abel Vesa <abel.vesa@....com>,
        "robh@...nel.org" <robh@...nel.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        dl-linux-imx <linux-imx@....com>
Subject: RE: [PATCH V2 1/2] soc: imx: Add SCU SoC info driver support



> -----Original Message-----
> From: Daniel Baluta [mailto:daniel.baluta@...il.com]
> Sent: Wednesday, May 15, 2019 7:47 PM
> To: Anson Huang <anson.huang@....com>
> Cc: catalin.marinas@....com; will.deacon@....com;
> shawnguo@...nel.org; s.hauer@...gutronix.de; kernel@...gutronix.de;
> festevam@...il.com; agross@...nel.org; maxime.ripard@...tlin.com;
> olof@...om.net; horms+renesas@...ge.net.au;
> jagan@...rulasolutions.com; bjorn.andersson@...aro.org; Leonard Crestez
> <leonard.crestez@....com>; marc.w.gonzalez@...e.fr;
> dinguyen@...nel.org; enric.balletbo@...labora.com;
> l.stach@...gutronix.de; Abel Vesa <abel.vesa@....com>; robh@...nel.org;
> linux-arm-kernel@...ts.infradead.org; linux-kernel@...r.kernel.org; dl-linux-
> imx <linux-imx@....com>
> Subject: Re: [PATCH V2 1/2] soc: imx: Add SCU SoC info driver support
> 
> Hi Anson,
> 
> Since you are going to send a new version for this please consider my
> comment inline.
> 
> <snip>
> 
> > +static u32 imx8qxp_soc_revision(void) {
> > +       struct imx_sc_msg_misc_get_soc_id msg;
> > +       struct imx_sc_rpc_msg *hdr = &msg.hdr;
> > +       u32 rev = 0;
> 
> No need to initialize this here.
> 
> > +       int ret;
> > +
> > +       hdr->ver = IMX_SC_RPC_VERSION;
> > +       hdr->svc = IMX_SC_RPC_SVC_MISC;
> > +       hdr->func = IMX_SC_MISC_FUNC_GET_CONTROL;
> > +       hdr->size = 3;
> > +
> > +       msg.data.send.control = IMX_SC_C_ID;
> > +       msg.data.send.resource = IMX_SC_R_SYSTEM;
> > +
> > +       ret = imx_scu_call_rpc(soc_ipc_handle, &msg, true);
> > +       if (ret) {
> > +               dev_err(&imx_scu_soc_pdev->dev,
> > +                       "get soc info failed, ret %d\n", ret);
> > +               /* return 0 means getting revision failed */
> 
> Just return 0 here. No need for rev.

OK, thanks.

Anson.

> > +               return rev;
> > +       }
> > +