linux-kernel - Re: [PATCH 2/3] au1200fb: fix DMA API abuse

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAOLZvyG14NvbgX4PA5aafk=reLcHbqDswqS-8j4+7QJMx02d7A@mail.gmail.com>
Date:   Wed, 15 May 2019 13:10:32 +0200
From:   Manuel Lauss <manuel.lauss@...il.com>
To:     Christoph Hellwig <hch@....de>
Cc:     Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>,
        Linux-MIPS <linux-mips@...r.kernel.org>,
        linux-fbdev <linux-fbdev@...r.kernel.org>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 2/3] au1200fb: fix DMA API abuse

Servus Christoph,

On Thu, May 9, 2019 at 7:39 PM Christoph Hellwig <hch@....de> wrote:
> Virtual addresses return from dma(m)_alloc_attrs are opaque in what
> backs then, and drivers must not poke into them.  Similarly caching
> modes are not supposed to be directly set by the driver.  Switch the
> driver to use the generic DMA API mmap helper to avoid these problems.
>
> Signed-off-by: Christoph Hellwig <hch@....de>
> ---
>  drivers/video/fbdev/au1200fb.c | 19 ++++---------------
>  1 file changed, 4 insertions(+), 15 deletions(-)

Runs fine on my test system.

Tested-by: Manuel Lauss <manuel.lauss@...il.com>