linux-kernel - Re: [PATCH 03/18] dt-bindings: soc: qcom: add IPA bindings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <fa75eb5e-90bc-b164-740f-4dbba8bccc46@linaro.org>
Date:   Wed, 15 May 2019 07:04:50 -0500
From:   Alex Elder <elder@...aro.org>
To:     Arnd Bergmann <arnd@...db.de>
Cc:     David Miller <davem@...emloft.net>,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        Ilias Apalodimas <ilias.apalodimas@...aro.org>,
        Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        Andy Gross <andy.gross@...aro.org>,
        David Brown <david.brown@...aro.org>, syadagir@...eaurora.org,
        mjavid@...eaurora.org, evgreen@...omium.org, benchan@...gle.com,
        ejcaruso@...gle.com, abhishek.esse@...il.com,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 03/18] dt-bindings: soc: qcom: add IPA bindings

On 5/15/19 2:03 AM, Arnd Bergmann wrote:
> On Sun, May 12, 2019 at 3:25 AM Alex Elder <elder@...aro.org> wrote:
>>
>> Add the binding definitions for the "qcom,ipa" device tree node.
>>
>> Signed-off-by: Alex Elder <elder@...aro.org>
>> ---
>>  .../devicetree/bindings/net/qcom,ipa.txt      | 164 ++++++++++++++++++
>>  1 file changed, 164 insertions(+)
>>  create mode 100644 Documentation/devicetree/bindings/net/qcom,ipa.txt
>>
>> diff --git a/Documentation/devicetree/bindings/net/qcom,ipa.txt b/Documentation/devicetree/bindings/net/qcom,ipa.txt
>> new file mode 100644
>> index 000000000000..2705e198f12e
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/net/qcom,ipa.txt
> 
> For new bindings, we should use the yaml format so we can verify the
> device tree files against the binding.

OK.  I didn't realize that was upstream yet.  I will convert.

>> +
>> +- reg:
>> +       Resources specifying the physical address spaces of the IPA and GSI.
>> +
>> +- reg-names:
>> +       The names of the two address space ranges defined by the "reg"
>> +       property.  Must be:
>> +               "ipa-reg"
>> +               "ipa-shared"
>> +               "gsi"
> 
> Those are three, not two ;-)

Oops!  I added one recently and I guess I missed that.  Thanks
for catching it.

					-Alex

> 
>         Arnd
>