lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 15 May 2019 18:05:30 +0530 From: Mukesh Ojha <mojha@...eaurora.org> To: Nathan Chancellor <natechancellor@...il.com>, Josh Poimboeuf <jpoimboe@...hat.com>, Peter Zijlstra <peterz@...radead.org> Cc: Nick Desaulniers <ndesaulniers@...gle.com>, clang-built-linux@...glegroups.com, linux-kernel@...r.kernel.org Subject: Re: [PATCH] objtool: Allow AR to be overridden with HOSTAR On 5/15/2019 4:10 AM, Nathan Chancellor wrote: > Currently, this Makefile hardcodes GNU ar, meaning that if it is not > available, there is no way to supply a different one and the build will > fail. > > $ make AR=llvm-ar CC=clang LD=ld.lld HOSTAR=llvm-ar HOSTCC=clang \ > HOSTLD=ld.lld HOSTLDFLAGS=-fuse-ld=lld defconfig modules_prepare > ... > AR /out/tools/objtool/libsubcmd.a > /bin/sh: 1: ar: not found > ... > > Follow the logic of HOST{CC,LD} and allow the user to specify a > different ar tool via HOSTAR (which is used elsewhere in other > tools/ Makefiles). > > Link: https://github.com/ClangBuiltLinux/linux/issues/481 > Signed-off-by: Nathan Chancellor <natechancellor@...il.com> Nice catch. Reviewed-by: Mukesh Ojha <mojha@...eaurora.org> Cheers, -Mukesh > --- > tools/objtool/Makefile | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/tools/objtool/Makefile b/tools/objtool/Makefile > index 53f8be0f4a1f..88158239622b 100644 > --- a/tools/objtool/Makefile > +++ b/tools/objtool/Makefile > @@ -7,11 +7,12 @@ ARCH := x86 > endif > > # always use the host compiler > +HOSTAR ?= ar > HOSTCC ?= gcc > HOSTLD ?= ld > +AR = $(HOSTAR) > CC = $(HOSTCC) > LD = $(HOSTLD) > -AR = ar > > ifeq ($(srctree),) > srctree := $(patsubst %/,%,$(dir $(CURDIR)))
Powered by blists - more mailing lists