linux-kernel - Re: [PATCH] rtc: test: enable wakeup flags

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <CAODwZ7t1UgPMeMYcadALD_gCa1Zp1fq65oF9fL65u5DTTft0Sw@mail.gmail.com>
Date:   Wed, 15 May 2019 16:53:57 +0300
From:   Roman Stratiienko <roman.stratiienko@...ballogic.com>
To:     Alexandre Belloni <alexandre.belloni@...tlin.com>
Cc:     a.zummo@...ertech.it, linux-rtc@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] rtc: test: enable wakeup flags

Hi Alexandre,

Thank you for the review.
See my answers below.


On Wed, May 15, 2019 at 3:32 PM Alexandre Belloni
<alexandre.belloni@...tlin.com> wrote:
>
> Hi,
>
> (You didn't use my correct email address, please update your kernel)

Fixed.

>
> On 15/05/2019 14:14:36+0300, roman.stratiienko@...ballogic.com wrote:
> > From: Roman Stratiienko <roman.stratiienko@...ballogic.com>
> >
> > Alarmtimer interface uses only the RTC with wekeup flags enabled.
> > Allow to use rtc-test driver with alarmtimer interface.
> >
> > Signed-off-by: Roman Stratiienko <roman.stratiienko@...ballogic.com>
> > ---
> >  drivers/rtc/rtc-test.c | 2 ++
> >  1 file changed, 2 insertions(+)
> >
> > diff --git a/drivers/rtc/rtc-test.c b/drivers/rtc/rtc-test.c
> > index 6c5f09c815e8..c839ae575c77 100644
> > --- a/drivers/rtc/rtc-test.c
> > +++ b/drivers/rtc/rtc-test.c
> > @@ -123,6 +123,8 @@ static int test_probe(struct platform_device *plat_dev)
> >
> >       platform_set_drvdata(plat_dev, rtd);
> >
> > +     device_init_wakeup(&plat_dev->dev, 1);
> > +
>
> The first created RTC doesn't have any alarm, so this must not be done
> for all the devices.

Thanks. I will fix this in v2.

>
> Also, this driver will never wake up the platform so I'm not sure it is
> relevant to test alarmtimers.

Alarmtimer interface relies only on RTC with alarm support,
but it also checks wake flags for some reason.
As far as rtc-test driver do have alarm support, I expect
that related drivers should use it.

Let me share some information about my use-case:
Alarmtimer support is required for generic AOSP bluedroid library.
To enable Bluetooth in Android on the devices that does not
have hardware RTC, enabling rtc-test driver is a good option.

>
> --
> Alexandre Belloni, Bootlin
> Embedded Linux and Kernel engineering
> https://bootlin.com

-- 
Best regards,
Roman Stratiienko
Global Logic Inc.