linux-kernel - Re: [PATCH] bsr: do not use assignment in if condition

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20190515141521.GA8999@kroah.com>
Date:   Wed, 15 May 2019 16:15:21 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Naveen Kumar Parna <parna.naveenkumar@...il.com>
Cc:     arnd@...db.de, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] bsr: do not use assignment in if condition

On Wed, May 15, 2019 at 07:16:37PM +0530, Naveen Kumar Parna wrote:
> On Wed, 15 May 2019 at 19:02, Greg KH <gregkh@...uxfoundation.org> wrote:
> 
> > On Wed, May 15, 2019 at 06:45:24PM +0530, parna.naveenkumar@...il.com
> > wrote:
> > > From: Naveen Kumar Parna <parna.naveenkumar@...il.com>
> > >
> > > checkpatch.pl does not like assignment in if condition
> > >
> > > Signed-off-by: Naveen Kumar Parna <parna.naveenkumar@...il.com>
> > > ---
> > >  drivers/char/bsr.c | 3 ++-
> > >  1 file changed, 2 insertions(+), 1 deletion(-)
> > >
> > > diff --git a/drivers/char/bsr.c b/drivers/char/bsr.c
> > > index a6cef548e01e..2b00748b83d2 100644
> > > --- a/drivers/char/bsr.c
> > > +++ b/drivers/char/bsr.c
> > > @@ -322,7 +322,8 @@ static int __init bsr_init(void)
> > >               goto out_err_2;
> > >       }
> > >
> > > -     if ((ret = bsr_create_devs(np)) < 0) {
> > > +     ret = bsr_create_devs(np);
> > > +     if (ret  < 0) {
> >
> > Checkpatch also probably does not like that if statement :(
> >
> I ran checkpatch script and it did not show any warning or error.
> 
> $ ./scripts/checkpatch.pl
> 0001-bsr-do-not-use-assignment-in-if-condition.patch
> total: 0 errors, 0 warnings, 9 lines checked
> 0001-bsr-do-not-use-assignment-in-if-condition.patch has no obvious style
> problems and is ready for submission.

Ok, then checkpatch missed it, but your eyes should have caught it.

When you are doing code style fixes outside of the drivers/staging/
area, you need to be very careful to be sure to get it right, as many
maintainers do not like the churn.

Please fix this up and resend.

thanks,

greg k-h