linux-kernel - RE: [PATCH 2/2] dt-bindings: arm: renesas: Add HopeRun RZ/G2[M] boards

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 15 May 2019 16:20:51 +0000
From:   Fabrizio Castro <fabrizio.castro@...renesas.com>
To:     Rob Herring <robh+dt@...nel.org>
CC:     Mark Rutland <mark.rutland@....com>,
        Simon Horman <horms@...ge.net.au>,
        Magnus Damm <magnus.damm@...il.com>,
        Thierry Reding <treding@...dia.com>,
        Andreas Färber <afaerber@...e.de>,
        Jonathan Cameron <Jonathan.Cameron@...wei.com>,
        Kevin Hilman <khilman@...libre.com>,
        Jagan Teki <jagan@...rulasolutions.com>,
        Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>,
        Martin Blumenstingl <martin.blumenstingl@...glemail.com>,
        "open list:MEDIA DRIVERS FOR RENESAS - FCP" 
        <linux-renesas-soc@...r.kernel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Geert Uytterhoeven <geert+renesas@...der.be>,
        Chris Paterson <Chris.Paterson2@...esas.com>,
        Biju Das <biju.das@...renesas.com>,
        "xu_shunji@...erun.com" <xu_shunji@...erun.com>
Subject: RE: [PATCH 2/2] dt-bindings: arm: renesas: Add HopeRun RZ/G2[M]
 boards

Hello Rob,

Thank you for your feedback!

> From: Rob Herring <robh+dt@...nel.org>
> Sent: 15 May 2019 14:42
> Subject: Re: [PATCH 2/2] dt-bindings: arm: renesas: Add HopeRun RZ/G2[M] boards
> 
> On Wed, May 15, 2019 at 6:45 AM Fabrizio Castro
> <fabrizio.castro@...renesas.com> wrote:
> >
> > This patch adds board HiHope RZ/G2M (the main board, powered by
> > the R8A774A1) and board HiHope RZ/G2 EX (the expansion board
> > that sits on top of the HiHope RZ/G2M). Both boards are made
> > by Jiangsu HopeRun Software Co., Ltd. (a.k.a. HopeRun).
> >
> > Signed-off-by: Fabrizio Castro <fabrizio.castro@...renesas.com>
> > Reviewed-by: Chris Paterson <Chris.Paterson2@...esas.com>
> >
> > ---
> > Useful links:
> > http://hihope.org/product/detail/rzg2
> > https://item.taobao.com/item.htm?spm=a2oq0.12575281.0.0.6bcf1debQpzkRS&ft=t&id=592177498472
> > http://www.hoperun.com/Cn/news/id/379
> >
> > We already know that the HiHope RZ/G2 EX will also sit on the
> > HiHope RZ/G2N, even though the HiHope RZ/G2N doesn't exist just
> > yet.
> 
> Seems like useful into to put in the commit msg.

Ok, will move the notes to the commit msg then for v2.

> 
> > ---
> >  Documentation/devicetree/bindings/arm/renesas.yaml | 8 ++++++++
> >  1 file changed, 8 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/arm/renesas.yaml b/Documentation/devicetree/bindings/arm/renesas.yaml
> > index 19f3798..95302b9 100644
> > --- a/Documentation/devicetree/bindings/arm/renesas.yaml
> > +++ b/Documentation/devicetree/bindings/arm/renesas.yaml
> > @@ -106,6 +106,14 @@ properties:
> >
> >        - description: RZ/G2M (R8A774A1)
> >          items:
> > +          - enum:
> > +              - hoperun,hihope-rzg2m # HopeRun HiHope RZ/G2M platform
> > +          - const: renesas,r8a774a1
> > +
> > +        items:
> 
> Did you run this thru the checks because this isn't valid json-schema.
> You can't have same keyword twice. This 'items' needs to be another
> list entry (i.e. add a '-').

Oops, sorry about that. Will fix in v2.

Thanks,
Fab

> 
> > +          - enum:
> > +              - hoperun,hihope-rzg2-ex # HopeRun expansion board for HiHope RZ/G2 platforms
> > +          - const: hoperun,hihope-rzg2m
> >            - const: renesas,r8a774a1
> >
> >        - description: RZ/G2E (R8A774C0)
> > --
> > 2.7.4
> >