linux-kernel - Re: [PATCH v6 3/4] x86/acrn: Use HYPERVISOR_CALLBACK

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190515172356.GL24212@zn.tnic>
Date:   Wed, 15 May 2019 19:23:56 +0200
From:   Borislav Petkov <bp@...en8.de>
To:     Zhao Yakui <yakui.zhao@...el.com>
Cc:     linux-kernel@...r.kernel.org, x86@...nel.org, tglx@...utronix.de,
        Jason Chen CJ <jason.cj.chen@...el.com>
Subject: Re: [PATCH v6 3/4] x86/acrn: Use HYPERVISOR_CALLBACK_VECTOR for ACRN
 guest upcall vector

On Tue, Apr 30, 2019 at 11:45:25AM +0800, Zhao Yakui wrote:
> @@ -30,6 +36,29 @@ static bool acrn_x2apic_available(void)
>  	return false;
>  }
>  
> +static void (*acrn_intr_handler)(void);
> +
> +__visible void __irq_entry acrn_hv_vector_handler(struct pt_regs *regs)
> +{
> +	struct pt_regs *old_regs = set_irq_regs(regs);
> +
> +	/*
> +	 * The hypervisor requires that the APIC EOI should be acked.
> +	 * If the APIC EOI is not acked, the APIC ISR bit for the
> +	 * HYPERVISOR_CALLBACK_VECTOR will not be cleared and then it
> +	 * will block the interrupt whose vector is lower than
> +	 * HYPERVISOR_CALLBACK_VECTOR.
> +	 */
> +	entering_ack_irq();

arch/x86/kernel/cpu/acrn.c: In function ‘acrn_hv_vector_handler’:
arch/x86/kernel/cpu/acrn.c:52:2: error: implicit declaration of function ‘entering_ack_irq’; did you mean ‘spin_lock_irq’? [-Werror=implicit-function-declaration]
  entering_ack_irq();
  ^~~~~~~~~~~~~~~~
  spin_lock_irq
arch/x86/kernel/cpu/acrn.c:58:2: error: implicit declaration of function ‘exiting_irq’; did you mean ‘in_irq’? [-Werror=implicit-function-declaration]
  exiting_irq();
  ^~~~~~~~~~~
  in_irq
cc1: some warnings being treated as errors
make[3]: *** [scripts/Makefile.build:278: arch/x86/kernel/cpu/acrn.o] Error 1
make[3]: *** Waiting for unfinished jobs....
make[2]: *** [scripts/Makefile.build:489: arch/x86/kernel/cpu] Error 2
make[1]: *** [scripts/Makefile.build:489: arch/x86/kernel] Error 2
make: *** [Makefile:1073: arch/x86] Error 2
make: *** Waiting for unfinished jobs....

Looks like it needs

+#include <asm/apic.h>

config attached.

-- 
Regards/Gruss,
    Boris.

Good mailing practices for 400: avoid top-posting and trim the reply.

View attachment "16-22-58-randconfig-x86_64-26856.cfg" of type "text/plain" (137180 bytes)