linux-kernel - Removal of dump_stack()s from /fs/ubifs/io.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <E44E4181-1CFB-493C-8023-147472049D19@cisco.com>
Date:   Wed, 15 May 2019 20:45:27 +0000
From:   "Shreya Gangan (shgangan)" <shgangan@...co.com>
To:     "linux-mtd@...ts.infradead.org" <linux-mtd@...ts.infradead.org>
CC:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Removal of dump_stack()s from  /fs/ubifs/io.c

Hi,

 /fs/ubifs/io.c has dump_stack() in multiple functions upon errors and sometimes warnings. 
Since the error and warning messages seem to be unique, the functional value of these dump_stacks is not apparent.
Why are these dump_stacks required and what issues might occur upon the removal of these?

Example: 
What is the usecase of the dump_stack in the following code snippet in file /fs/ubifs/io.c?
    if (err) {
    		ubifs_err(c, "changing %d bytes in LEB %d failed, error %d",
    			  len, lnum, err);
    		ubifs_ro_mode(c, err);
    		dump_stack();
    	}

Regards,