linux-kernel - Re: [PATCH V5 1/4] spi: tegra114: add support for gpio based CS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 15 May 2019 12:29:00 +0100
From:   Mark Brown <broonie@...nel.org>
To:     Sowjanya Komatineni <skomatineni@...dia.com>
Cc:     Jonathan Hunter <jonathanh@...dia.com>,
        "thierry.reding@...il.com" <thierry.reding@...il.com>,
        Laxman Dewangan <ldewangan@...dia.com>,
        Krishna Yarlagadda <kyarlagadda@...dia.com>,
        "linux-tegra@...r.kernel.org" <linux-tegra@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-spi@...r.kernel.org" <linux-spi@...r.kernel.org>
Subject: Re: [PATCH V5 1/4] spi: tegra114: add support for gpio based CS

On Wed, May 15, 2019 at 11:24:22AM +0000, Sowjanya Komatineni wrote:

> > Please fix your mail client to word wrap within paragraphs at something
> substantially less than 80 columns.  Doing this makes your messages much
> easier to read and reply to.

> I did changed but looks like it didn't made diff. Will try with different email client.

Yeah, the behaviour is exactly the same - it's not only not wrapping
your content but also reflowing quoted content.

> > Please don't ignore review comments, people are generally making them
> for a reason and are likely to have the same concerns if issues remain
> unaddressed.  Having to repeat the same comments can get repetitive and
> make people question the value of time spent reviewing.  If you disagree
> with the review comments that's fine but you need to reply and discuss
> your concerns so that the reviewer can understand your decisions.

> If you are referring to comment from Jon on updating commit, I didn't ignored. I am just waiting if any more comments from you or others before posting updated patch. 

That was more about the continuing issues with mail formatting.

> But I see you applied patch now. So how should I post with updated commit?

No, it's fine.  It would have been better to have a clearer commit
message but I think the usage makes it reasonably clear in the final
code why that was done and honestly "the hardware doesn't support all
the features we need to properly control devices" is an extremely common
reason for using GPIO chip selects even when hardware support is
available.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)