linux-kernel - Re: [PATCH] staging: rtl8723bs: core: rtw

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190516182538.GA4025@hari-Inspiron-1545>
Date:   Thu, 16 May 2019 23:55:39 +0530
From:   Hariprasad Kelam <hariprasad.kelam@...il.com>
To:     Dan Carpenter <dan.carpenter@...cle.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Hardik Singh Rathore <hardiksingh.k@...il.com>,
        devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: rtl8723bs: core: rtw_recv: fix warning
 Comparison to NULL

On Thu, May 16, 2019 at 11:00:56AM +0300, Dan Carpenter wrote:
> On Wed, May 15, 2019 at 11:15:36PM +0530, Hariprasad Kelam wrote:
> > @@ -1042,7 +1042,7 @@ sint sta2ap_data_frame(
> >  		}
> >  
> >  		*psta = rtw_get_stainfo(pstapriv, pattrib->src);
> > -		if (*psta == NULL) {
> > +		if (!*psta == NULL) {
>                     ^^^^^^^^^^^^^^
> It's surprising that this didn't cause some kind of warning somewhere...

Thanks for pointing out this error. Here my intention is to write
                if(!*psta) 
but somehow i missed it .

Will resend this patch after correcting the same.Like below

> -           if (*psta == NULL) {
> > +           if (!*psta) {


Do let me know if the above propose change is fine or not.
> 
> >  			RT_TRACE(_module_rtl871x_recv_c_, _drv_err_, ("can't get psta under AP_MODE; drop pkt\n"));
> >  			DBG_871X("issue_deauth to sta =" MAC_FMT " for the reason(7)\n", MAC_ARG(pattrib->src));
> >  
> 
> regards,
> dan carpenter