[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <CAPcyv4jJ4AX7OKLBMo3SSomrneRef6OB=qpBESiQwAinnM+How@mail.gmail.com>
Date: Thu, 16 May 2019 11:27:36 -0700
From: Dan Williams <dan.j.williams@...el.com>
To: Qian Cai <cai@....pw>
Cc: Andrew Morton <akpm@...ux-foundation.org>,
Vishal L Verma <vishal.l.verma@...el.com>,
Dave Jiang <dave.jiang@...el.com>,
Keith Busch <keith.busch@...el.com>,
"Weiny, Ira" <ira.weiny@...el.com>,
linux-nvdimm <linux-nvdimm@...ts.01.org>,
Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] nvdimm: fix compilation warnings with W=1
On Thu, May 16, 2019 at 9:05 AM Qian Cai <cai@....pw> wrote:
>
> Several places (dimm_devs.c, core.c etc) include label.h but only
> label.c uses NSINDEX_SIGNATURE, so move its definition to label.c
> instead.
>
> In file included from drivers/nvdimm/dimm_devs.c:23:
> drivers/nvdimm/label.h:41:19: warning: 'NSINDEX_SIGNATURE' defined but
> not used [-Wunused-const-variable=]
>
> Also, some places abuse "/**" which is only reserved for the kernel-doc.
>
> drivers/nvdimm/bus.c:648: warning: cannot understand function prototype:
> 'struct attribute_group nd_device_attribute_group = '
> drivers/nvdimm/bus.c:677: warning: cannot understand function prototype:
> 'struct attribute_group nd_numa_attribute_group = '
>
> Those are just some member assignments for the "struct attribute_group"
> instances and it can't be expressed in the kernel-doc.
Ah, good point, I missed that.
> Reviewed-by: Vishal Verma <vishal.l.verma@...el.com>
> Signed-off-by: Qian Cai <cai@....pw>
Looks good, I'll pull this in for a post -rc1 update.
Powered by blists - more mailing lists