linux-kernel - Re: [PATCH v5] proc/sysctl: add shared variables for range check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <201905161132.CC4C2F3@keescook>
Date:   Thu, 16 May 2019 11:33:21 -0700
From:   Kees Cook <keescook@...omium.org>
To:     Matteo Croce <mcroce@...hat.com>
Cc:     Andrew Morton <akpm@...ux-foundation.org>,
        LKML <linux-kernel@...r.kernel.org>,
        "linux-fsdevel@...r.kernel.org" <linux-fsdevel@...r.kernel.org>,
        Matthew Wilcox <willy@...radead.org>
Subject: Re: [PATCH v5] proc/sysctl: add shared variables for range check

On Thu, May 16, 2019 at 06:09:53PM +0200, Matteo Croce wrote:
> On Tue, Apr 30, 2019 at 8:14 PM Kees Cook <keescook@...omium.org> wrote:
> >
> > On Tue, Apr 30, 2019 at 11:01 AM Matteo Croce <mcroce@...hat.com> wrote:
> > >
> > > In the sysctl code the proc_dointvec_minmax() function is often used to
> > > validate the user supplied value between an allowed range. This function
> > > uses the extra1 and extra2 members from struct ctl_table as minimum and
> > > maximum allowed value.
> > >
> [...]
> > >
> > > Signed-off-by: Matteo Croce <mcroce@...hat.com>
> >
> > Acked-by: Kees Cook <keescook@...omium.org>
> >
> > --
> > Kees Cook
> 
> Hi all,
> 
> just a ping about this patch. Any tought, suggestion, concern or criticism?

Andrew, does this look okay to pick up after -rc2 for -next?

-- 
Kees Cook