lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [day] [month] [year] [list]
Date:   Thu, 16 May 2019 05:50:22 +0000
From:   "S.j. Wang" <shengjiu.wang@....com>
To:     Mark Brown <broonie@...nel.org>
CC:     "brian.austin@...rus.com" <brian.austin@...rus.com>,
        "Paul.Handrigan@...rus.com" <Paul.Handrigan@...rus.com>,
        "lgirdwood@...il.com" <lgirdwood@...il.com>,
        "perex@...ex.cz" <perex@...ex.cz>,
        "tiwai@...e.com" <tiwai@...e.com>,
        "alsa-devel@...a-project.org" <alsa-devel@...a-project.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] ASoC: cs42xx8: Add reset gpio handling

Hi Mark

> 
> On Mon, Apr 29, 2019 at 10:46:03AM +0000, S.j. Wang wrote:
> 
> > +	cs42xx8->gpio_reset = of_get_named_gpio(dev->of_node, "gpio-
> reset", 0);
> > +	if (gpio_is_valid(cs42xx8->gpio_reset)) {
> > +		ret = devm_gpio_request_one(dev, cs42xx8->gpio_reset,
> > +				GPIOF_OUT_INIT_LOW, "cs42xx8 reset");
> 
> You should just be able to request the GPIO by name without going
> through of_get_named_gpio() using devm_gpio_get().
> 
Will send v2.

> > @@ -559,6 +577,7 @@ static int cs42xx8_runtime_resume(struct device
> > *dev)
> >
> >  	regcache_cache_only(cs42xx8->regmap, false);
> >
> > +	regcache_mark_dirty(cs42xx8->regmap);
> >  	ret = regcache_sync(cs42xx8->regmap);
> >  	if (ret) {
> >  		dev_err(dev, "failed to sync regmap: %d\n", ret);
> 
> This looks like an unrelated bugfix.

Will separate it to another patch.

Best regards
Wang shengjiu

Powered by blists - more mailing lists