linux-kernel - Re: [PATCH 3.18 78/86] bridge: Fix error path for kobject_init_and

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 16 May 2019 07:57:08 +0200
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     "Tobin C. Harding" <me@...in.cc>
Cc:     linux-kernel@...r.kernel.org, stable@...r.kernel.org,
        "Tobin C. Harding" <tobin@...nel.org>,
        "David S. Miller" <davem@...emloft.net>
Subject: Re: [PATCH 3.18 78/86] bridge: Fix error path for
 kobject_init_and_add()

On Thu, May 16, 2019 at 06:48:40AM +1000, Tobin C. Harding wrote:
> On Wed, May 15, 2019 at 12:55:55PM +0200, Greg Kroah-Hartman wrote:
> > From: "Tobin C. Harding" <tobin@...nel.org>
> > 
> > [ Upstream commit bdfad5aec1392b93495b77b864d58d7f101dc1c1 ]
> 
> Greg you are not going to back port all of these kobject fixes are you?
> There is going to be a _lot_ of them.  I'm not super comfortable
> generating all this work for you.  And besides that, I keep making
> mistakes (reference to last nights find of double free in powerpc that
> you reviewed already), then we have to back port those too.
> 
> For the record I've been going through all uses of kobject and splitting
> them into categories
> 
>  1. Broken
>  2. Too complex to immediately tell
>  3. Done correctly
> 
> I'm not getting many in category #3, let's hope that some in #1 and #2 are
> my misunderstanding and that many in #2 should be in #3.  I'm having fun
> fixing them but I shudder at making life hard for other people.

I took this one as it was forwarded on to me by David Miller as a fix to
be queued up for networking issues.

If a maintainer wants to mark the patch for stable, I'll be glad to take
it, but I'm not going to be going and digging all of these out by hand
an backporting them :)

thanks,

greg k-h