linux-kernel - Re: [RESEND PATCH] nvdimm: fix some compilation warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 15 May 2019 20:31:31 -0400
From:   Qian Cai <cai@....pw>
To:     Dan Williams <dan.j.williams@...el.com>
Cc:     Andrew Morton <akpm@...ux-foundation.org>,
        Vishal L Verma <vishal.l.verma@...el.com>,
        Dave Jiang <dave.jiang@...el.com>,
        Keith Busch <keith.busch@...el.com>,
        "Weiny, Ira" <ira.weiny@...el.com>,
        linux-nvdimm <linux-nvdimm@...ts.01.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [RESEND PATCH] nvdimm: fix some compilation warnings


>>                }
>> 
>> diff --git a/drivers/nvdimm/bus.c b/drivers/nvdimm/bus.c
>> index 7ff684159f29..2eb6a6cfe9e4 100644
>> --- a/drivers/nvdimm/bus.c
>> +++ b/drivers/nvdimm/bus.c
>> @@ -642,7 +642,7 @@ static struct attribute *nd_device_attributes[] = {
>>        NULL,
>> };
>> 
>> -/**
>> +/*
>>  * nd_device_attribute_group - generic attributes for all devices on an nd bus
>>  */
>> struct attribute_group nd_device_attribute_group = {
>> @@ -671,7 +671,7 @@ static umode_t nd_numa_attr_visible(struct kobject *kobj, struct attribute *a,
>>        return a->mode;
>> }
>> 
>> -/**
>> +/*
>>  * nd_numa_attribute_group - NUMA attributes for all devices on an nd bus
>>  */
> 
> Lets just fix this to be a valid kernel-doc format for a struct.
> 
> @@ -672,7 +672,7 @@ static umode_t nd_numa_attr_visible(struct kobject
> *kobj, struct attribute *a,
> }
> 
> /**
> - * nd_numa_attribute_group - NUMA attributes for all devices on an nd bus
> + * struct nd_numa_attribute_group - NUMA attributes for all devices
> on an nd bus
>  */
> struct attribute_group nd_numa_attribute_group = {
>        .attrs = nd_numa_attributes,

This won’t work because kernel-doc is to explain a struct definition, but this is a just an assignment.
The "struct attribute_group” kernel-doc is in include/linux/sysfs.h.