linux-kernel - RE: [EXT] Re: [v1] drm/arm/mali-dp: Disable checking for required pixel clock rate

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <AM0PR04MB4865435E9FA2D61E2D9A238EE20A0@AM0PR04MB4865.eurprd04.prod.outlook.com>
Date:   Thu, 16 May 2019 09:42:46 +0000
From:   Wen He <wen.he_1@....com>
To:     Robin Murphy <robin.murphy@....com>,
        "dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "liviu.dudau@....com" <liviu.dudau@....com>
CC:     Leo Li <leoyang.li@....com>
Subject: RE: [EXT] Re: [v1] drm/arm/mali-dp: Disable checking for required
 pixel clock rate



> -----Original Message-----
> From: Robin Murphy [mailto:robin.murphy@....com]
> Sent: 2019年5月16日 1:14
> To: Wen He <wen.he_1@....com>; dri-devel@...ts.freedesktop.org;
> linux-kernel@...r.kernel.org; liviu.dudau@....com
> Cc: Leo Li <leoyang.li@....com>
> Subject: [EXT] Re: [v1] drm/arm/mali-dp: Disable checking for required pixel
> clock rate
> 
> Caution: EXT Email
> 
> On 15/05/2019 03:42, Wen He wrote:
> > Disable checking for required pixel clock rate if ARCH_LAYERSCPAE is
> > enable.
> >
> > Signed-off-by: Alison Wang <alison.wang@....com>
> > Signed-off-by: Wen He <wen.he_1@....com>
> > ---
> > change in description:
> >       - This check that only supported one pixel clock required clock rate
> >       compare with dts node value. but we have supports 4 pixel clock
> >       for ls1028a board.
> >   drivers/gpu/drm/arm/malidp_crtc.c | 2 ++
> >   1 file changed, 2 insertions(+)
> >
> > diff --git a/drivers/gpu/drm/arm/malidp_crtc.c
> > b/drivers/gpu/drm/arm/malidp_crtc.c
> > index 56aad288666e..bb79223d9981 100644
> > --- a/drivers/gpu/drm/arm/malidp_crtc.c
> > +++ b/drivers/gpu/drm/arm/malidp_crtc.c
> > @@ -36,11 +36,13 @@ static enum drm_mode_status
> > malidp_crtc_mode_valid(struct drm_crtc *crtc,
> >
> >       if (req_rate) {
> >               rate = clk_round_rate(hwdev->pxlclk, req_rate);
> > +#ifndef CONFIG_ARCH_LAYERSCAPE
> 
> What about multiplatform builds? The kernel config doesn't tell you what
> hardware you're actually running on.
> 

Hi Robin,

Thanks for your reply.

In fact, Only one platform integrates this IP when CONFIG_ARCH_LAYERSCAPE is set.
Although this are not good ways, but I think it won't be a problem under multiplatform builds.

Best Regards,
Wen

> Robin.
> 
> >               if (rate != req_rate) {
> >                       DRM_DEBUG_DRIVER("pxlclk doesn't support %ld
> Hz\n",
> >                                        req_rate);
> >                       return MODE_NOCLOCK;
> >               }
> > +#endif
> >       }
> >
> >       return MODE_OK;
> >