linux-kernel - Re: [PATCH] drm/bridge: Remove duplicate header

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190516134304.GK14820@pendragon.ideasonboard.com>
Date:   Thu, 16 May 2019 16:43:04 +0300
From:   Laurent Pinchart <laurent.pinchart@...asonboard.com>
To:     Sabyasachi Gupta <sabyasachi.linux@...il.com>
Cc:     architt@...eaurora.org, a.hajda@...sung.com, airlied@...ux.ie,
        Souptick Joarder <jrdr.linux@...il.com>,
        dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drm/bridge: Remove duplicate header

Hi Sabyasachi,

On Thu, May 16, 2019 at 06:45:04PM +0530, Sabyasachi Gupta wrote:
> On Tue, May 14, 2019 at 1:05 PM Laurent Pinchart wrote:
> > On Tue, May 14, 2019 at 01:01:41PM +0530, Sabyasachi Gupta wrote:
> > > Remove drm/drm_panel.h which is included more than once
> > >
> > > Signed-off-by: Sabyasachi Gupta <sabyasachi.linux@...il.com>
> > > ---
> > >  drivers/gpu/drm/bridge/panel.c | 1 -
> > >  1 file changed, 1 deletion(-)
> > >
> > > diff --git a/drivers/gpu/drm/bridge/panel.c b/drivers/gpu/drm/bridge/panel.c
> > > index 7cbaba2..402b318 100644
> > > --- a/drivers/gpu/drm/bridge/panel.c
> > > +++ b/drivers/gpu/drm/bridge/panel.c
> > > @@ -15,7 +15,6 @@
> > >  #include <drm/drm_crtc_helper.h>
> > >  #include <drm/drm_encoder.h>
> > >  #include <drm/drm_modeset_helper_vtables.h>
> > > -#include <drm/drm_panel.h>
> >
> > Which tree is this against ? The patch applies on neither drm-next nor
> > drm-misc-next.
> >
> 
> It is against linux-next tree

You will likely have to rebase it on top of the drm-next or
drm-next-misc branch.

> > While at it, could you you reorder the other header alphabetically to
> > make this kind of issue easier to notice ?
>
> It is already arranged in alphabetical order

There's an #include <drm/drm_panel.h> at the top of the list of
includes. That's the one that is out of place.

> > >
> > >  struct panel_bridge {
> > >       struct drm_bridge bridge;

-- 
Regards,

Laurent Pinchart