linux-kernel - Re: [alsa-devel] [PATCH] ASoC: AK4458: add regulator for ak4458

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 16 May 2019 14:11:31 +0000
From:   Viorel Suman <viorel.suman@....com>
To:     "festevam@...il.com" <festevam@...il.com>
CC:     dl-linux-imx <linux-imx@....com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "colin.king@...onical.com" <colin.king@...onical.com>,
        "viorel.suman@...il.com" <viorel.suman@...il.com>,
        "broonie@...nel.org" <broonie@...nel.org>,
        "tiwai@...e.com" <tiwai@...e.com>,
        "lgirdwood@...il.com" <lgirdwood@...il.com>,
        "S.j. Wang" <shengjiu.wang@....com>,
        "Julia.Lawall@...6.fr" <Julia.Lawall@...6.fr>,
        Daniel Baluta <daniel.baluta@....com>,
        "perex@...ex.cz" <perex@...ex.cz>,
        "alsa-devel@...a-project.org" <alsa-devel@...a-project.org>
Subject: Re: [alsa-devel] [PATCH] ASoC: AK4458: add regulator for ak4458

On Jo, 2019-05-16 at 10:14 -0300, Fabio Estevam wrote:
> On Thu, May 16, 2019 at 10:02 AM Viorel Suman <viorel.suman@....com> wrote:
> 
> > 
> > +       for (i = 0; i < ARRAY_SIZE(ak4458->supplies); i++)
> > +               ak4458->supplies[i].supply = ak4458_supply_names[i];
> > +
> > +       ret = devm_regulator_bulk_get(ak4458->dev, ARRAY_SIZE(ak4458->supplies),
> > +                                     ak4458->supplies);
> > +       if (ret != 0) {
> > +               dev_err(ak4458->dev, "Failed to request supplies: %d\n", ret);
> > +               return ret;
> This would break existing users that do not pass the regulators in device tree.
> 
> Ok, in this case there is no ak4458 user in any dts, so that would not
> be an issue.
> 
> Please update the dt-bindings with the regulator entries.

Thanks, will send in V2.

/Viorel