linux-kernel - Re: Bad virt_to_phys since commit 54c7a8916a887f35

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 16 May 2019 16:23:27 +0200
From:   Christoph Hellwig <hch@....de>
To:     Mark Rutland <mark.rutland@....com>
Cc:     Mike Rapoport <rppt@...ux.ibm.com>, Christoph Hellwig <hch@....de>,
        linux-kernel@...r.kernel.org, Steven Price <steven.price@....com>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Will Deacon <will.deacon@....com>,
        Catalin Marinas <catalin.marinas@....com>
Subject: Re: Bad virt_to_phys since commit 54c7a8916a887f35

On Thu, May 16, 2019 at 03:21:19PM +0100, Mark Rutland wrote:
> >  void __weak free_initrd_mem(unsigned long start, unsigned long end)
> >  {
> > +       if (!start)
> > +               return;
> > +
> >         free_reserved_area((void *)start, (void *)end, POISON_FREE_INITMEM,
> >                         "initrd");
> >  }
> 
> I think this should work, given Steven's patch checks the same thing.
> 
> I don't have a preference as to which patch should be taken, so I'll
> leave that to Christoph.

We still have plenty of architectures not using the generic
free_initrd_mem, so checking it in the caller gives us better
coverage.