linux-kernel - Re: [PATCH 2/3] thermal: sun50i: add thermal driver for h6

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190516150252.hf4u3bloo37chy6q@flea>
Date:   Thu, 16 May 2019 17:02:52 +0200
From:   Maxime Ripard <maxime.ripard@...tlin.com>
To:     Yangtao Li <tiny.windzz@...il.com>, mark.rutland@....com,
        daniel.lezcano@...aro.org, catalin.marinas@....com,
        will.deacon@....com, bjorn.andersson@...aro.org,
        mchehab+samsung@...nel.org, paulmck@...ux.ibm.com,
        stefan.wahren@...e.com, linux-pm@...r.kernel.org, wens@...e.org,
        jagan@...rulasolutions.com, andy.gross@...aro.org,
        rui.zhang@...el.com, devicetree@...r.kernel.org,
        marc.w.gonzalez@...e.fr, edubezval@...il.com,
        enric.balletbo@...labora.com, robh+dt@...nel.org,
        Jonathan.Cameron@...wei.com, linux-arm-kernel@...ts.infradead.org,
        gregkh@...uxfoundation.org, linux-kernel@...r.kernel.org,
        olof@...om.net, davem@...emloft.net
Subject: Re: [PATCH 2/3] thermal: sun50i: add thermal driver for h6

Hi,

On Sun, May 12, 2019 at 11:41:28PM +0200, Ondřej Jirman wrote:
> > > +static int tsens_get_temp(void *data, int *temp)
> > > +{
> > > +	struct tsensor *s = data;
> > > +	struct tsens_device *tmdev = s->tmdev;
> > > +	int val;
> > > +
> > > +	regmap_read(tmdev->regmap, tmdev->chip->temp_data_base +
> > > +		    0x4 * s->id, &val);
> > > +
> > > +	if (unlikely(val == 0))
> > > +		return -EBUSY;
> >
> > I'm not sure why a val equals to 0 would be associated with EBUSY?
>
> Thermal zone driver can (will) call get_temp before we got the
> first interrupt and the thermal data. In that case val will be 0.
>
> Resulting in:
>
>  (val + offset) * scale = (-2794) * -67 = 187198
>
> 187°C and immediate shutdown during boot - based on cirtical
> temperature being reached.
>
> Busy here means, get_temp does not yet have data. Thermal zone
> driver just reports any error to dmesg output.

Ah, that makes sense.

I guess if we're switching to an interrupt-based driver, then we can
just use a waitqueue, or is get_temp supposed to be atomic?

Maxime

--
Maxime Ripard, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)