linux-kernel - Re: [GIT PULL 1/4] ARM: SoC platform updates

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aad06de6-b85c-b549-5653-45f9c4ebb384@free.fr>
Date:   Thu, 16 May 2019 17:59:58 +0200
From:   Marc Gonzalez <marc.w.gonzalez@...e.fr>
To:     Linus Torvalds <torvalds@...ux-foundation.org>,
        Linus Walleij <linus.walleij@...aro.org>,
        arm-soc <arm@...nel.org>
Cc:     LKML <linux-kernel@...r.kernel.org>,
        Linux ARM <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [GIT PULL 1/4] ARM: SoC platform updates

On 16/05/2019 17:33, Linus Torvalds wrote:

> On Wed, May 15, 2019 at 11:43 PM Olof Johansson wrote:
>>
>> SoC updates, mostly refactorings and cleanups of old legacy platforms.
>> Major themes this release:
> 
> Hmm. This brings in a new warning:
> 
>   drivers/clocksource/timer-ixp4xx.c:78:20: warning:
> ‘ixp4xx_read_sched_clock’ defined but not used [-Wunused-function]
> 
> because that drivers is enabled for build testing, but that function
> is only used under
> 
>   #ifdef CONFIG_ARM
>         sched_clock_register(ixp4xx_read_sched_clock, 32, timer_freq);
>   #endif
> 
> It's not clear why that #ifdef is there. This driver only builds
> non-ARM when COMPILE_TEST is enabled, and that #ifdef actually breaks
> that build test.
> 
> I'm going to remove that #ifdef in my merge, because I do *not* want
> to see new warnings, and it doesn't seem to make any sense.
> 
> Maybe that's the wrong resolution, please holler and let me know if
> you want something else.

Hello BDFL,

Your email client did something strange by changing

	linux-arm-kernel@...ts.infradead.org
to
	"linux-alpha@...r.kernel.org" <linux-arm-kernel@...ts.infradead.org>

which is odd  ;-)


As for your actual remark, I note that Olof has an arm/late branch
(which I assume he plans to submit in a few days?) which contains
the change you mention:

https://git.kernel.org/pub/scm/linux/kernel/git/arm/arm-soc.git/log/?h=arm/late
https://git.kernel.org/pub/scm/linux/kernel/git/arm/arm-soc.git/commit/?h=arm/late&id=5cb9de627e25421e2e2edaff6360c84d32cd3c02

Regards.