linux-kernel - Re: mm: use down_read_killable for locking mmap_sem in access_remote

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190516170034.GO13687@blackbody.suse.cz>
Date:   Thu, 16 May 2019 19:00:35 +0200
From:   Michal Koutný <mkoutny@...e.com>
To:     Konstantin Khlebnikov <khlebnikov@...dex-team.ru>
Cc:     mkoutny@...e.cz, linux-mm@...ck.org, akpm@...ux-foundation.org,
        oleg@...hat.com, linux-kernel@...r.kernel.org
Subject: Re: mm: use down_read_killable for locking mmap_sem in
 access_remote_vm


On Wed, May 15, 2019 at 11:48:32AM +0300, Konstantin Khlebnikov <khlebnikov@...dex-team.ru> wrote:
> This function ignores any error like reading from unmapped area and
> returns only size of successful transfer. It never returned any error codes.
This is a point I missed. Hence no need to adjust consumers of
__access_remote_vm() (they won't actually handle -EINTR correctly w/out
further changes). This beats my original idea with simplicity.


Reviewed-by: Michal Koutný <mkoutny@...e.com>

Michal