linux-kernel - Re: [GIT PULL 1/4] ARM: SoC platform updates

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 16 May 2019 10:10:41 -0700
From:   Olof Johansson <olof@...om.net>
To:     Arnd Bergmann <arnd@...db.de>
Cc:     Linus Torvalds <torvalds@...ux-foundation.org>,
        Linus Walleij <linus.walleij@...aro.org>,
        ARM SoC <arm@...nel.org>,
        Linux List Kernel Mailing <linux-kernel@...r.kernel.org>,
        "linux-alpha@...r.kernel.org" <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [GIT PULL 1/4] ARM: SoC platform updates

On Thu, May 16, 2019 at 8:53 AM Arnd Bergmann <arnd@...db.de> wrote:
>
> On Thu, May 16, 2019 at 5:34 PM Linus Torvalds
> <torvalds@...ux-foundation.org> wrote:
> >
> > On Wed, May 15, 2019 at 11:43 PM Olof Johansson <olof@...om.net> wrote:
> > >
> > > SoC updates, mostly refactorings and cleanups of old legacy platforms.
> > > Major themes this release:
> >
> > Hmm. This brings in a new warning:
> >
> >   drivers/clocksource/timer-ixp4xx.c:78:20: warning:
> > ‘ixp4xx_read_sched_clock’ defined but not used [-Wunused-function]
> >
> > because that drivers is enabled for build testing, but that function
> > is only used under
> >
> >   #ifdef CONFIG_ARM
> >         sched_clock_register(ixp4xx_read_sched_clock, 32, timer_freq);
> >   #endif
> >
> > It's not clear why that #ifdef is there. This driver only builds
> > non-ARM when COMPILE_TEST is enabled, and that #ifdef actually breaks
> > that build test.
> >
> > I'm going to remove that #ifdef in my merge, because I do *not* want
> > to see new warnings, and it doesn't seem to make any sense.
> >
> > Maybe that's the wrong resolution, please holler and let me know if
> > you want something else.
>
> As far as I can tell, that is the best fix, thanks for the cleanup!

Yeah, this was entirely on me -- it was found and fixed on linux-next,
and Linus Walleij sent patches. However, as I was staging these pull
requests, I applied them to a branch of fixes that I'm collecting for
later this week instead of on top of the one I was sending.

Thanks for fixing it up.


-Olof