linux-kernel - Re: [PATCH] USB: serial: mos7840: Prefer 'unsigned int' to bare use of 'unsigned'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190517074248.GD28564@localhost>
Date:   Fri, 17 May 2019 09:42:48 +0200
From:   Johan Hovold <johan@...nel.org>
To:     parna.naveenkumar@...il.com
Cc:     johan@...nel.org, gregkh@...uxfoundation.org,
        linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] USB: serial: mos7840: Prefer 'unsigned int' to bare use
 of 'unsigned'

On Thu, May 16, 2019 at 06:37:59PM +0530, parna.naveenkumar@...il.com wrote:
> From: Naveen Kumar Parna <parna.naveenkumar@...il.com>
> 
> This fixes checkpatch.pl warning "WARNING: Prefer 'unsigned int' to
> bare use of 'unsigned'".

Please don't run checkpatch.pl on code that already in the kernel
(possibly with the exception of staging). Use it on your own patches
before you submit them if you want, and even then don't blindly follow
what checkpatch says.

Minor coding style issues are better left alone to avoid adding noise
and making code forensic and backports harder.

And in this case, there's not even anything wrong with the current code.

Johan