linux-kernel - Re: [PATCH] s390: mark __cpacf_check_opcode() and cpacf_query_func() as __always

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 17 May 2019 17:47:05 +0900
From:   Masahiro Yamada <yamada.masahiro@...ionext.com>
To:     Martin Schwidefsky <schwidefsky@...ibm.com>
Cc:     Heiko Carstens <heiko.carstens@...ibm.com>,
        linux-s390 <linux-s390@...r.kernel.org>,
        Arnd Bergmann <arnd@...db.de>,
        Laura Abbott <labbott@...hat.com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH] s390: mark __cpacf_check_opcode() and cpacf_query_func()
 as __always_inline

On Fri, May 17, 2019 at 5:09 PM Martin Schwidefsky
<schwidefsky@...ibm.com> wrote:
>
> On Fri, 17 May 2019 15:54:24 +0900
> Masahiro Yamada <yamada.masahiro@...ionext.com> wrote:
>
> > Commit e60fb8bf68d4 ("s390/cpacf: mark scpacf_query() as __always_inline")
> > was not enough to make sure to meet the 'i' (immediate) constraint for the
> > asm operands.
> >
> > With CONFIG_OPTIMIZE_INLINING enabled, Laura Abbott reported error
> > with gcc 9.1.1:
> >
> >   In file included from arch/s390/crypto/prng.c:29:
> >   ./arch/s390/include/asm/cpacf.h: In function 'cpacf_query_func':
> >   ./arch/s390/include/asm/cpacf.h:170:2: warning: asm operand 3 probably doesn't match constraints
> >     170 |  asm volatile(
> >         |  ^~~
> >   ./arch/s390/include/asm/cpacf.h:170:2: error: impossible constraint in 'asm'
> >
> > Add more __always_inline to force inlining.
> >
> > Fixes: 9012d011660e ("compiler: allow all arches to enable CONFIG_OPTIMIZE_INLINING")
> > Reported-by: Laura Abbott <labbott@...hat.com>
> > Signed-off-by: Masahiro Yamada <yamada.masahiro@...ionext.com>
>
> Added to our internal tree and I will add it to s390/linux soon. Thanks.
>
> Do you have a Kconfig patch in the works to enable OPTIMIZE_INLINING?
> Otherwise we could just add it.

No.
It is up to you.


Thanks.


-- 
Best Regards
Masahiro Yamada