linux-kernel - Re: [PATCH] rcu: Remove unused variable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190517105111.GW4319@dell>
Date:   Fri, 17 May 2019 11:51:11 +0100
From:   Lee Jones <lee.jones@...aro.org>
To:     Philippe Mazenauer <philippe.mazenauer@...look.de>
Cc:     "Paul E. McKenney" <paulmck@...ux.ibm.com>,
        Josh Triplett <josh@...htriplett.org>,
        Steven Rostedt <rostedt@...dmis.org>,
        Mathieu Desnoyers <mathieu.desnoyers@...icios.com>,
        Lai Jiangshan <jiangshanlai@...il.com>,
        Joel Fernandes <joel@...lfernandes.org>,
        "rcu@...r.kernel.org" <rcu@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] rcu: Remove unused variable

On Fri, 17 May 2019, Philippe Mazenauer wrote:

> Variable 'rdp' is set but not used in synchronize_rcu_expidited(). The
> macro per_cpu_ptr() used to set the value of 'rdp' has no side effect.
> 
> ../kernel/rcu/tree_exp.h:768:19: warning: variable ‘rdp’ set but not used [-Wunused-but-set-variable]
>    struct rcu_data *rdp;
>                     ^~~
> 
> Signed-off-by: Philippe Mazenauer <philippe.mazenauer@...look.de>
> ---
>  kernel/rcu/tree_exp.h | 2 --
>  1 file changed, 2 deletions(-)

Looks reasonable:

Acked-by: Lee Jones <lee.jones@...aro.org>

-- 
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog