linux-kernel - Re: [PATCH] arm64: dts: ls1028a: fix watchdog device node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 17 May 2019 10:37:30 +0800
From:   Shawn Guo <shawnguo@...nel.org>
To:     Chuanhua Han <chuanhua.han@....com>
Cc:     leoyang.li@....com, mark.rutland@....com,
        linux-arm-kernel@...ts.infradead.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        Zhang Ying-22455 <ying.zhang22455@....com>
Subject: Re: [PATCH] arm64: dts: ls1028a: fix watchdog device node

On Thu, May 09, 2019 at 03:06:57PM +0800, Chuanhua Han wrote:
> ls1028a platform uses sp805 watchdog, and use 1/16 platform clock as
> timer clock, this patch fix device tree node.
> 
> Signed-off-by: Zhang Ying-22455 <ying.zhang22455@....com>
> Signed-off-by: Chuanhua Han <chuanhua.han@....com>
> ---
>  .../arm64/boot/dts/freescale/fsl-ls1028a.dtsi | 19 ++++++++++++-------
>  1 file changed, 12 insertions(+), 7 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> index b04581249f0b..1510b1858246 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> @@ -285,13 +285,18 @@
>  			#interrupt-cells = <2>;
>  		};
>  
> -		wdog0: watchdog@...0000 {
> -			compatible = "fsl,ls1028a-wdt", "fsl,imx21-wdt";
> -			reg = <0x0 0x23c0000 0x0 0x10000>;
> -			interrupts = <GIC_SPI 59 IRQ_TYPE_LEVEL_HIGH>;
> -			clocks = <&clockgen 4 1>;
> -			big-endian;
> -			status = "disabled";
> +		cluster1_core0_watchdog: wdt@...0000 {

Keep 'watchdog' as the node name, and keep nodes sort in unit-address.

Shawn

> +			compatible = "arm,sp805", "arm,primecell";
> +			reg = <0x0 0xc000000 0x0 0x1000>;
> +			clocks = <&clockgen 4 15>, <&clockgen 4 15>;
> +			clock-names = "apb_pclk", "wdog_clk";
> +		};
> +
> +		cluster1_core1_watchdog: wdt@...0000 {
> +			compatible = "arm,sp805", "arm,primecell";
> +			reg = <0x0 0xc010000 0x0 0x1000>;
> +			clocks = <&clockgen 4 15>, <&clockgen 4 15>;
> +			clock-names = "apb_pclk", "wdog_clk";
>  		};
>  
>  		sata: sata@...0000 {
> -- 
> 2.17.1
>